diff options
| author | Jeremy Lainé <jeremy.laine@m4x.org> | 2010-12-10 17:13:22 +0000 |
|---|---|---|
| committer | Jeremy Lainé <jeremy.laine@m4x.org> | 2010-12-10 17:13:22 +0000 |
| commit | e700e9ae7f84292cdf6d839f43c162959f7223f4 (patch) | |
| tree | 34baa5d224b3d98eec7f5ad9e6f225269346a36c /src/QXmppRemoteMethod.cpp | |
| parent | 6af39f910eff70130329e8e0031cd3ffdf589af3 (diff) | |
| download | qxmpp-e700e9ae7f84292cdf6d839f43c162959f7223f4.tar.gz | |
add some warnings in RPC code
Diffstat (limited to 'src/QXmppRemoteMethod.cpp')
| -rw-r--r-- | src/QXmppRemoteMethod.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/QXmppRemoteMethod.cpp b/src/QXmppRemoteMethod.cpp index ada8beca..749de5ab 100644 --- a/src/QXmppRemoteMethod.cpp +++ b/src/QXmppRemoteMethod.cpp @@ -24,11 +24,10 @@ #include "QXmppRemoteMethod.h" #include "QXmppClient.h" #include "QXmppUtils.h" -#include "QXmppConfiguration.h" +#include <QDebug> #include <QEventLoop> #include <QTimer> -#include <qdebug.h> QXmppRemoteMethod::QXmppRemoteMethod(const QString &jid, const QString &method, const QVariantList &args, QXmppClient *client) : QObject(client), m_client(client) @@ -41,6 +40,8 @@ QXmppRemoteMethod::QXmppRemoteMethod(const QString &jid, const QString &method, QXmppRemoteMethodResult QXmppRemoteMethod::call( ) { + // FIXME : spinning an event loop is a VERY bad idea, it can cause + // us to lose incoming packets QEventLoop loop(this); connect( this, SIGNAL(callDone()), &loop, SLOT(quit())); QTimer::singleShot(30000,&loop, SLOT(quit())); // Timeout incase the other end hangs... |