From e700e9ae7f84292cdf6d839f43c162959f7223f4 Mon Sep 17 00:00:00 2001
From: Jeremy Lainé <jeremy.laine@m4x.org>
Date: Fri, 10 Dec 2010 17:13:22 +0000
Subject: add some warnings in RPC code

---
 src/QXmppRemoteMethod.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/QXmppRemoteMethod.cpp')

diff --git a/src/QXmppRemoteMethod.cpp b/src/QXmppRemoteMethod.cpp
index ada8beca..749de5ab 100644
--- a/src/QXmppRemoteMethod.cpp
+++ b/src/QXmppRemoteMethod.cpp
@@ -24,11 +24,10 @@
 #include "QXmppRemoteMethod.h"
 #include "QXmppClient.h"
 #include "QXmppUtils.h"
-#include "QXmppConfiguration.h"
 
+#include <QDebug>
 #include <QEventLoop>
 #include <QTimer>
-#include <qdebug.h>
 
 QXmppRemoteMethod::QXmppRemoteMethod(const QString &jid, const QString &method, const QVariantList &args, QXmppClient *client) :
         QObject(client), m_client(client)
@@ -41,6 +40,8 @@ QXmppRemoteMethod::QXmppRemoteMethod(const QString &jid, const QString &method,
 
 QXmppRemoteMethodResult QXmppRemoteMethod::call( )
 {
+    // FIXME : spinning an event loop is a VERY bad idea, it can cause
+    // us to lose incoming packets
     QEventLoop loop(this);
     connect( this, SIGNAL(callDone()), &loop, SLOT(quit()));
     QTimer::singleShot(30000,&loop, SLOT(quit())); // Timeout incase the other end hangs...
-- 
cgit v1.2.3