diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-12-11 14:10:08 -0600 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2019-05-02 16:03:30 +0200 |
| commit | 14e04766199babe08b6e82d4a31ff66b8061f5a7 (patch) | |
| tree | 1bdb00e43da13992b4aea99e9ab0d983fbf2058f /fs/debugfs | |
| parent | 30f4038178c85646c222e4160282413dc0116364 (diff) | |
ip6mr: Fix potential Spectre v1 vulnerability
[ Upstream commit 69d2c86766da2ded2b70281f1bf242cb0d58a778 ]
vr.mifi is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/ipv6/ip6mr.c:1845 ip6mr_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
net/ipv6/ip6mr.c:1919 ip6mr_compat_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
Fix this by sanitizing vr.mifi before using it to index mrt->vif_table'
Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].
[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2
Change-Id: Iac12abbdf84e1cba5c2a61e8385505c94e5f02b0
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/debugfs')
0 files changed, 0 insertions, 0 deletions