Add QXmppStartTlsPacket to replace hard-coded XML in TLS code

2 files changed, 94 insertions, 0 deletions

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index a9c3e87d..262a9474 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -46,6 +46,7 @@ add_simple_test(qxmppserver)
 add_simple_test(qxmppsessioniq)
 add_simple_test(qxmppsocks)
 add_simple_test(qxmppstanza)
+add_simple_test(qxmppstarttlspacket)
 add_simple_test(qxmppstreamfeatures)
 add_simple_test(qxmppstunmessage)
 add_simple_test(qxmppvcardiq)
diff --git a/tests/qxmppstarttlspacket/tst_qxmppstarttlspacket.cpp b/tests/qxmppstarttlspacket/tst_qxmppstarttlspacket.cpp
new file mode 100644
index 00000000..1b6119d8
--- /dev/null
+++ b/tests/qxmppstarttlspacket/tst_qxmppstarttlspacket.cpp
@@ -0,0 +1,93 @@
+/*
+ * Copyright (C) 2008-2019 The QXmpp developers
+ *
+ * Author:
+ *  Linus Jahn
+ *
+ * Source:
+ *  https://github.com/qxmpp-project/qxmpp
+ *
+ * This file is a part of QXmpp library.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ */
+
+#include <QObject>
+
+#include "QXmppStartTlsPacket.h"
+#include "util.h"
+
+class tst_QXmppStartTlsPacket : public QObject
+{
+    Q_OBJECT
+
+private slots:
+    void testBasic_data();
+    void testBasic();
+};
+
+void tst_QXmppStartTlsPacket::testBasic_data()
+{
+    QTest::addColumn<QByteArray>("xml");
+    QTest::addColumn<bool>("valid");
+    QTest::addColumn<QXmppStartTlsPacket::Type>("type");
+
+#define ROW(name, xml, valid, type) \
+    QTest::newRow(name) \
+        << QByteArrayLiteral(xml) \
+        << valid \
+        << type
+
+    ROW("starttls", R"(<starttls xmlns="urn:ietf:params:xml:ns:xmpp-tls"/>)", true, QXmppStartTlsPacket::StartTls);
+    ROW("proceed", R"(<proceed xmlns="urn:ietf:params:xml:ns:xmpp-tls"/>)", true, QXmppStartTlsPacket::Proceed);
+    ROW("failure", R"(<failure xmlns="urn:ietf:params:xml:ns:xmpp-tls"/>)", true, QXmppStartTlsPacket::Failure);
+
+    ROW("invalid-tag", R"(<invalid-tag-name xmlns="urn:ietf:params:xml:ns:xmpp-tls"/>)", false, QXmppStartTlsPacket::StartTls);
+
+#undef ROW
+}
+
+void tst_QXmppStartTlsPacket::testBasic()
+{
+    QFETCH(QByteArray, xml);
+    QFETCH(bool, valid);
+    QFETCH(QXmppStartTlsPacket::Type, type);
+
+    QDomDocument doc;
+    QCOMPARE(doc.setContent(xml, true), true);
+    QCOMPARE(QXmppStartTlsPacket::isStartTlsPacket(doc.documentElement()), valid);
+    QCOMPARE(QXmppStartTlsPacket::isStartTlsPacket(doc.documentElement(), type), valid);
+
+    // test other types return false
+    for (auto testValue : {QXmppStartTlsPacket::StartTls,
+                            QXmppStartTlsPacket::Proceed,
+                            QXmppStartTlsPacket::Failure}) {
+        QCOMPARE(QXmppStartTlsPacket::isStartTlsPacket(doc.documentElement(), testValue), testValue == type && valid);
+    }
+
+    if (valid) {
+        QXmppStartTlsPacket packet;
+        parsePacket(packet, xml);
+        QCOMPARE(packet.type(), type);
+        serializePacket(packet, xml);
+
+        QXmppStartTlsPacket packet2(type);
+        serializePacket(packet2, xml);
+
+        QXmppStartTlsPacket packet3;
+        packet3.setType(type);
+        serializePacket(packet2, xml);
+    }
+}
+
+QTEST_MAIN(tst_QXmppStartTlsPacket)
+#include "tst_qxmppstarttlspacket.moc"