diff options
| author | Linus Jahn <lnj@kaidan.im> | 2022-12-26 21:35:16 +0100 |
|---|---|---|
| committer | Linus Jahn <lnj@kaidan.im> | 2022-12-26 22:00:07 +0100 |
| commit | 46995fd3fd7da4d1b035f71a1279c041b2871ffd (patch) | |
| tree | 788517dbefa88fc1680b05a97e84f0e1d7403815 /src/client | |
| parent | 71442ab927cd5c1c235528442fe3706f33e7ff6e (diff) | |
| download | qxmpp-46995fd3fd7da4d1b035f71a1279c041b2871ffd.tar.gz | |
Disable Qt keywords completely
Previously we had the policy that no qt keywords were allowed in headers
that may be included by users. However since there was no automatic test
verifying that in some places keywords were still used.
This now disables qt keywords completely, also in tests and examples. Qt
keywords are in general no good or really good idea as they even
conflict with the standard library (`emit` at least).
In some cases in the examples I just removed the slot tag if the
functions didn't need to be slots (anymore).
Closes #503.
Diffstat (limited to 'src/client')
23 files changed, 129 insertions, 131 deletions
diff --git a/src/client/QXmppArchiveManager.cpp b/src/client/QXmppArchiveManager.cpp index 6cca75d3..6eee0d6c 100644 --- a/src/client/QXmppArchiveManager.cpp +++ b/src/client/QXmppArchiveManager.cpp @@ -27,12 +27,12 @@ bool QXmppArchiveManager::handleStanza(const QDomElement &element) if (QXmppArchiveChatIq::isArchiveChatIq(element)) { QXmppArchiveChatIq archiveIq; archiveIq.parse(element); - emit archiveChatReceived(archiveIq.chat(), archiveIq.resultSetReply()); + Q_EMIT archiveChatReceived(archiveIq.chat(), archiveIq.resultSetReply()); return true; } else if (QXmppArchiveListIq::isArchiveListIq(element)) { QXmppArchiveListIq archiveIq; archiveIq.parse(element); - emit archiveListReceived(archiveIq.chats(), archiveIq.resultSetReply()); + Q_EMIT archiveListReceived(archiveIq.chats(), archiveIq.resultSetReply()); return true; } else if (QXmppArchivePrefIq::isArchivePrefIq(element)) { // TODO: handle preference iq diff --git a/src/client/QXmppAtmManager.h b/src/client/QXmppAtmManager.h index 9fbd5a63..9a0ab446 100644 --- a/src/client/QXmppAtmManager.h +++ b/src/client/QXmppAtmManager.h @@ -24,11 +24,10 @@ protected: /// \cond void setClient(QXmppClient *client) override; -private slots: - void handleMessageReceived(const QXmppMessage &message); +private: + Q_SLOT void handleMessageReceived(const QXmppMessage &message); /// \endcond -private: QFuture<void> makeTrustDecisions(const QString &encryption, const QMultiHash<QString, QByteArray> &keyIdsForAuthentication, const QMultiHash<QString, QByteArray> &keyIdsForDistrusting); QFuture<void> handleMessage(const QXmppMessage &message); @@ -40,10 +39,12 @@ private: QFuture<QXmpp::SendResult> sendTrustMessage(const QString &encryption, const QList<QXmppTrustMessageKeyOwner> &keyOwners, const QString &recipientJid); + /// \cond inline QXmppAtmTrustStorage *trustStorage() const { return dynamic_cast<QXmppAtmTrustStorage *>(QXmppTrustManager::trustStorage()); } + /// \endcond friend class tst_QXmppAtmManager; }; diff --git a/src/client/QXmppAttentionManager.cpp b/src/client/QXmppAttentionManager.cpp index 661208e6..55bdc179 100644 --- a/src/client/QXmppAttentionManager.cpp +++ b/src/client/QXmppAttentionManager.cpp @@ -206,7 +206,7 @@ void QXmppAttentionManager::handleMessageReceived(const QXmppMessage &message) // check rate limit if (!d->checkRateLimit(bareJid)) { - emit attentionRequestRateLimited(message); + Q_EMIT attentionRequestRateLimited(message); return; } @@ -215,7 +215,7 @@ void QXmppAttentionManager::handleMessageReceived(const QXmppMessage &message) isTrusted = rosterManager->getRosterBareJids().contains(bareJid); } - emit attentionRequested(message, isTrusted); + Q_EMIT attentionRequested(message, isTrusted); } QXmppAttentionManagerPrivate::QXmppAttentionManagerPrivate(QXmppAttentionManager *parent, quint8 allowedAttempts, QTime timeFrame) diff --git a/src/client/QXmppBookmarkManager.cpp b/src/client/QXmppBookmarkManager.cpp index d1038382..45680e7e 100644 --- a/src/client/QXmppBookmarkManager.cpp +++ b/src/client/QXmppBookmarkManager.cpp @@ -144,7 +144,7 @@ bool QXmppBookmarkManager::handleStanza(const QDomElement &stanza) if (iq.type() == QXmppIq::Result) { d->bookmarks = iq.bookmarks(); d->bookmarksReceived = true; - emit bookmarksReceived(d->bookmarks); + Q_EMIT bookmarksReceived(d->bookmarks); } return true; } else if (!d->pendingId.isEmpty() && stanza.attribute("id") == d->pendingId) { @@ -152,7 +152,7 @@ bool QXmppBookmarkManager::handleStanza(const QDomElement &stanza) iq.parse(stanza); if (iq.type() == QXmppIq::Result) { d->bookmarks = d->pendingBookmarks; - emit bookmarksReceived(d->bookmarks); + Q_EMIT bookmarksReceived(d->bookmarks); } d->pendingId = QString(); return true; diff --git a/src/client/QXmppCall.h b/src/client/QXmppCall.h index f13a8cc3..a504ff29 100644 --- a/src/client/QXmppCall.h +++ b/src/client/QXmppCall.h @@ -55,39 +55,36 @@ public: QXmppCallStream *audioStream() const; QXmppCallStream *videoStream() const; -signals: /// \brief This signal is emitted when a call is connected. /// /// Once this signal is emitted, you can connect a QAudioOutput and /// QAudioInput to the call. You can determine the appropriate clockrate /// and the number of channels by calling payloadType(). - void connected(); + Q_SIGNAL void connected(); /// \brief This signal is emitted when a call is finished. /// /// Note: Do not delete the call in the slot connected to this signal, /// instead use deleteLater(). - void finished(); + Q_SIGNAL void finished(); /// \brief This signal is emitted when the remote party is ringing. - void ringing(); + Q_SIGNAL void ringing(); /// \brief This signal is emitted when the call state changes. - void stateChanged(QXmppCall::State state); + Q_SIGNAL void stateChanged(QXmppCall::State state); /// \brief This signal is emitted when a stream is created. - void streamCreated(QXmppCallStream *stream); + Q_SIGNAL void streamCreated(QXmppCallStream *stream); -public slots: - void accept(); - void hangup(); - void addVideo(); - -private slots: - void localCandidatesChanged(); - void terminated(); + Q_SLOT void accept(); + Q_SLOT void hangup(); + Q_SLOT void addVideo(); private: + Q_SLOT void localCandidatesChanged(); + Q_SLOT void terminated(); + QXmppCall(const QString &jid, QXmppCall::Direction direction, QXmppCallManager *parent); QXmppCallPrivate *d; diff --git a/src/client/QXmppCarbonManager.cpp b/src/client/QXmppCarbonManager.cpp index 61a19778..8727688a 100644 --- a/src/client/QXmppCarbonManager.cpp +++ b/src/client/QXmppCarbonManager.cpp @@ -98,9 +98,9 @@ bool QXmppCarbonManager::handleStanza(const QDomElement &element) message.setCarbonForwarded(true); if (sent) { - emit messageSent(message); + Q_EMIT messageSent(message); } else { - emit messageReceived(message); + Q_EMIT messageReceived(message); } return true; diff --git a/src/client/QXmppClient.cpp b/src/client/QXmppClient.cpp index f69bc29b..174c4219 100644 --- a/src/client/QXmppClient.cpp +++ b/src/client/QXmppClient.cpp @@ -863,7 +863,7 @@ bool QXmppClient::injectMessage(QXmppMessage &&message) auto handled = MessagePipeline::process(this, d->extensions, std::move(message)); if (!handled) { // no extension handled the message - emit messageReceived(message); + Q_EMIT messageReceived(message); } return handled; } @@ -890,7 +890,7 @@ void QXmppClient::_q_reconnect() void QXmppClient::_q_socketStateChanged(QAbstractSocket::SocketState socketState) { Q_UNUSED(socketState); - emit stateChanged(state()); + Q_EMIT stateChanged(state()); } /// At connection establishment, send initial presence. @@ -902,8 +902,8 @@ void QXmppClient::_q_streamConnected() d->isActive = true; // notify managers - emit connected(); - emit stateChanged(QXmppClient::ConnectedState); + Q_EMIT connected(); + Q_EMIT stateChanged(QXmppClient::ConnectedState); // send initial presence if (d->stream->isAuthenticated()) { @@ -914,8 +914,8 @@ void QXmppClient::_q_streamConnected() void QXmppClient::_q_streamDisconnected() { // notify managers - emit disconnected(); - emit stateChanged(QXmppClient::DisconnectedState); + Q_EMIT disconnected(); + Q_EMIT stateChanged(QXmppClient::DisconnectedState); } void QXmppClient::_q_streamError(QXmppClient::Error err) @@ -936,7 +936,7 @@ void QXmppClient::_q_streamError(QXmppClient::Error err) } // notify managers - emit error(err); + Q_EMIT error(err); } QXmppLogger *QXmppClient::logger() const @@ -968,6 +968,6 @@ void QXmppClient::setLogger(QXmppLogger *logger) d->logger, &QXmppLogger::updateCounter); } - emit loggerChanged(d->logger); + Q_EMIT loggerChanged(d->logger); } } diff --git a/src/client/QXmppDiscoveryManager.cpp b/src/client/QXmppDiscoveryManager.cpp index fa0a19da..bdea6ede 100644 --- a/src/client/QXmppDiscoveryManager.cpp +++ b/src/client/QXmppDiscoveryManager.cpp @@ -322,9 +322,9 @@ bool QXmppDiscoveryManager::handleStanza(const QDomElement &element) case QXmppIq::Error: // handle all replies if (receivedIq.queryType() == QXmppDiscoveryIq::InfoQuery) { - emit infoReceived(receivedIq); + Q_EMIT infoReceived(receivedIq); } else if (receivedIq.queryType() == QXmppDiscoveryIq::ItemsQuery) { - emit itemsReceived(receivedIq); + Q_EMIT itemsReceived(receivedIq); } return true; diff --git a/src/client/QXmppEntityTimeManager.cpp b/src/client/QXmppEntityTimeManager.cpp index 17daa844..eb88fc0f 100644 --- a/src/client/QXmppEntityTimeManager.cpp +++ b/src/client/QXmppEntityTimeManager.cpp @@ -79,7 +79,7 @@ bool QXmppEntityTimeManager::handleStanza(const QDomElement &element) if (element.tagName() == "iq" && QXmppEntityTimeIq::isEntityTimeIq(element)) { QXmppEntityTimeIq entityTime; entityTime.parse(element); - emit timeReceived(entityTime); + Q_EMIT timeReceived(entityTime); return true; } diff --git a/src/client/QXmppHttpUploadManager.cpp b/src/client/QXmppHttpUploadManager.cpp index 46242d5f..2fe2994e 100644 --- a/src/client/QXmppHttpUploadManager.cpp +++ b/src/client/QXmppHttpUploadManager.cpp @@ -47,7 +47,7 @@ struct QXmppHttpUploadPrivate { if (!finished) { finished = true; - emit q->finished(result()); + Q_EMIT q->finished(result()); } } void reportProgress(quint64 sent, quint64 total) @@ -61,7 +61,7 @@ struct QXmppHttpUploadPrivate if (bytesSent != sent || bytesTotal != total) { bytesSent = sent; bytesTotal = total; - emit q->progressChanged(); + Q_EMIT q->progressChanged(); } } [[nodiscard]] QXmppHttpUpload::Result result() const diff --git a/src/client/QXmppMamManager.cpp b/src/client/QXmppMamManager.cpp index 7bbbdd74..9050c02f 100644 --- a/src/client/QXmppMamManager.cpp +++ b/src/client/QXmppMamManager.cpp @@ -120,14 +120,14 @@ bool QXmppMamManager::handleStanza(const QDomElement &element) itr->second.messages.append(std::move(message)); } else { // signal-based API - emit archivedMessageReceived(queryId, message); + Q_EMIT archivedMessageReceived(queryId, message); } return true; } } else if (QXmppMamResultIq::isMamResultIq(element)) { QXmppMamResultIq result; result.parse(element); - emit resultsRecieved(result.id(), result.resultSetReply(), result.complete()); + Q_EMIT resultsRecieved(result.id(), result.resultSetReply(), result.complete()); return true; } diff --git a/src/client/QXmppMessageReceiptManager.cpp b/src/client/QXmppMessageReceiptManager.cpp index 660964e7..b464ed18 100644 --- a/src/client/QXmppMessageReceiptManager.cpp +++ b/src/client/QXmppMessageReceiptManager.cpp @@ -37,7 +37,7 @@ bool QXmppMessageReceiptManager::handleMessage(const QXmppMessage &message) // Buggy clients also mark carbon messages as received; to avoid this // we check whether sender and receiver have the same bare JID. if (QXmppUtils::jidToBareJid(message.from()) != QXmppUtils::jidToBareJid(message.to())) { - emit messageDelivered(message.from(), message.receiptId()); + Q_EMIT messageDelivered(message.from(), message.receiptId()); } return true; } diff --git a/src/client/QXmppMucManager.cpp b/src/client/QXmppMucManager.cpp index 0076122b..7954734b 100644 --- a/src/client/QXmppMucManager.cpp +++ b/src/client/QXmppMucManager.cpp @@ -61,7 +61,7 @@ QXmppMucRoom *QXmppMucManager::addRoom(const QString &roomJid) this, &QXmppMucManager::_q_roomDestroyed); // emit signal - emit roomAdded(room); + Q_EMIT roomAdded(room); } return room; } @@ -100,7 +100,7 @@ bool QXmppMucManager::handleStanza(const QDomElement &element) } } if (room->d->permissionsQueue.isEmpty()) { - emit room->permissionsReceived(room->d->permissions.values()); + Q_EMIT room->permissionsReceived(room->d->permissions.values()); } return true; } @@ -110,7 +110,7 @@ bool QXmppMucManager::handleStanza(const QDomElement &element) QXmppMucRoom *room = d->rooms.value(iq.from()); if (room && iq.type() == QXmppIq::Result && !iq.form().isNull()) { - emit room->configurationReceived(iq.form()); + Q_EMIT room->configurationReceived(iq.form()); return true; } } @@ -136,7 +136,7 @@ void QXmppMucManager::_q_messageReceived(const QXmppMessage &msg) // process room invitations const QString roomJid = msg.mucInvitationJid(); if (!roomJid.isEmpty() && (!d->rooms.contains(roomJid) || !d->rooms.value(roomJid)->isJoined())) { - emit invitationReceived(roomJid, msg.from(), msg.mucInvitationReason()); + Q_EMIT invitationReceived(roomJid, msg.from(), msg.mucInvitationReason()); } } @@ -342,7 +342,7 @@ void QXmppMucRoom::setNickName(const QString &nickName) d->client->sendPacket(packet); } else { d->nickName = nickName; - emit nickNameChanged(nickName); + Q_EMIT nickNameChanged(nickName); } } @@ -520,19 +520,19 @@ void QXmppMucRoom::_q_disconnected() const QStringList removed = d->participants.keys(); d->participants.clear(); for (const auto &jid : removed) { - emit participantRemoved(jid); + Q_EMIT participantRemoved(jid); } - emit participantsChanged(); + Q_EMIT participantsChanged(); // update available actions if (d->allowedActions != NoAction) { d->allowedActions = NoAction; - emit allowedActionsChanged(d->allowedActions); + Q_EMIT allowedActionsChanged(d->allowedActions); } // emit "left" signal if we had joined the room if (wasJoined) { - emit left(); + Q_EMIT left(); } } @@ -550,7 +550,7 @@ void QXmppMucRoom::_q_discoveryInfoReceived(const QXmppDiscoveryIq &iq) if (name != d->name) { d->name = name; - emit nameChanged(name); + Q_EMIT nameChanged(name); } } } @@ -565,10 +565,10 @@ void QXmppMucRoom::_q_messageReceived(const QXmppMessage &message) const QString subject = message.subject(); if (!subject.isEmpty()) { d->subject = subject; - emit subjectChanged(subject); + Q_EMIT subjectChanged(subject); } - emit messageReceived(message); + Q_EMIT messageReceived(message); } void QXmppMucRoom::_q_presenceReceived(const QXmppPresence &presence) @@ -610,38 +610,38 @@ void QXmppMucRoom::_q_presenceReceived(const QXmppPresence &presence) if (newActions != d->allowedActions) { d->allowedActions = newActions; - emit allowedActionsChanged(d->allowedActions); + Q_EMIT allowedActionsChanged(d->allowedActions); } } if (added) { - emit participantAdded(jid); - emit participantsChanged(); + Q_EMIT participantAdded(jid); + Q_EMIT participantsChanged(); if (jid == d->ownJid()) { // request room information if (d->discoManager) { d->discoManager->requestInfo(d->jid); } - emit joined(); + Q_EMIT joined(); } } else { - emit participantChanged(jid); + Q_EMIT participantChanged(jid); } } else if (presence.type() == QXmppPresence::Unavailable) { if (d->participants.contains(jid)) { d->participants.insert(jid, presence); - emit participantRemoved(jid); + Q_EMIT participantRemoved(jid); d->participants.remove(jid); - emit participantsChanged(); + Q_EMIT participantsChanged(); // check whether this was our own presence if (jid == d->ownJid()) { const QString newNick = presence.mucItem().nick(); if (!newNick.isEmpty() && newNick != d->nickName) { d->nickName = newNick; - emit nickNameChanged(newNick); + Q_EMIT nickNameChanged(newNick); return; } @@ -649,34 +649,34 @@ void QXmppMucRoom::_q_presenceReceived(const QXmppPresence &presence) if (presence.mucStatusCodes().contains(307)) { const QString actor = presence.mucItem().actor(); const QString reason = presence.mucItem().reason(); - emit kicked(actor, reason); + Q_EMIT kicked(actor, reason); } // clear chat room participants const QStringList removed = d->participants.keys(); d->participants.clear(); for (const auto &jid : removed) { - emit participantRemoved(jid); + Q_EMIT participantRemoved(jid); } - emit participantsChanged(); + Q_EMIT participantsChanged(); // update available actions if (d->allowedActions != NoAction) { d->allowedActions = NoAction; - emit allowedActionsChanged(d->allowedActions); + Q_EMIT allowedActionsChanged(d->allowedActions); } // notify user we left the room - emit left(); + Q_EMIT left(); } } } else if (presence.type() == QXmppPresence::Error) { if (presence.isMucSupported()) { // emit error - emit error(presence.error()); + Q_EMIT error(presence.error()); // notify the user we left the room - emit left(); + Q_EMIT left(); } } } diff --git a/src/client/QXmppOutgoingClient.cpp b/src/client/QXmppOutgoingClient.cpp index 271ec8b9..7d1ad6a3 100644 --- a/src/client/QXmppOutgoingClient.cpp +++ b/src/client/QXmppOutgoingClient.cpp @@ -325,7 +325,7 @@ void QXmppOutgoingClient::_q_socketDisconnected() d->redirectHost = QString(); d->redirectPort = 0; } else { - emit disconnected(); + Q_EMIT disconnected(); } } @@ -338,7 +338,7 @@ void QXmppOutgoingClient::socketSslErrors(const QList<QSslError> &errors) } // relay signal - emit sslErrors(errors); + Q_EMIT sslErrors(errors); // if configured, ignore the errors if (configuration().ignoreSslErrors()) { @@ -354,7 +354,7 @@ void QXmppOutgoingClient::socketError(QAbstractSocket::SocketError socketError) // some network error occurred during startup -> try next available SRV record server d->connectToNextDNSHost(); } else { - emit error(QXmppClient::SocketError); + Q_EMIT error(QXmppClient::SocketError); } } @@ -419,7 +419,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) // give client opportunity to handle stanza bool handled = false; - emit elementReceived(nodeRecv, handled); + Q_EMIT elementReceived(nodeRecv, handled); if (handled) { return; } @@ -535,7 +535,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) // otherwise we are done d->sessionStarted = true; - emit connected(); + Q_EMIT connected(); } else if (ns == ns_stream && nodeRecv.tagName() == "error") { // handle redirects const auto otherHost = nodeRecv.firstChildElement("see-other-host"); @@ -551,7 +551,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) } else { d->xmppStreamError = QXmppStanza::Error::UndefinedCondition; } - emit error(QXmppClient::XmppStreamError); + Q_EMIT error(QXmppClient::XmppStreamError); } else if (ns == ns_sasl) { if (!d->saslClient) { warning("SASL stanza received, but no mechanism selected"); @@ -584,7 +584,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) } else { d->xmppStreamError = QXmppStanza::Error::UndefinedCondition; } - emit error(QXmppClient::XmppStreamError); + Q_EMIT error(QXmppClient::XmppStreamError); warning("Authentication failure"); disconnectFromHost(); @@ -608,7 +608,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) d->sendStreamManagementEnable(); } else { // we are connected now - emit connected(); + Q_EMIT connected(); } } else if (QXmppBindIq::isBindIq(nodeRecv) && id == d->bindId) { QXmppBindIq bind; @@ -637,12 +637,12 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) d->sendStreamManagementEnable(); } else { // we are connected now - emit connected(); + Q_EMIT connected(); } } } else if (bind.type() == QXmppIq::Error) { d->xmppStreamError = bind.error().condition(); - emit error(QXmppClient::XmppStreamError); + Q_EMIT error(QXmppClient::XmppStreamError); warning("Resource binding error received: " + bind.error().text()); disconnectFromHost(); } @@ -657,7 +657,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) // xmpp connection made d->sessionStarted = true; - emit connected(); + Q_EMIT connected(); } else if (QXmppNonSASLAuthIq::isNonSASLAuthIq(nodeRecv)) { if (type == "result") { bool digest = !nodeRecv.firstChildElement("query").firstChildElement("digest").isNull(); @@ -707,7 +707,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) iq.setError(error); sendPacket(iq); } else { - emit iqReceived(iqPacket); + Q_EMIT iqReceived(iqPacket); } } } else if (nodeRecv.tagName() == "presence") { @@ -715,13 +715,13 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) presence.parse(nodeRecv); // emit presence - emit presenceReceived(presence); + Q_EMIT presenceReceived(presence); } else if (nodeRecv.tagName() == "message") { QXmppMessage message; message.parse(nodeRecv); // emit message - emit messageReceived(message); + Q_EMIT messageReceived(message); } } else if (QXmppStreamManagementEnabled::isStreamManagementEnabled(nodeRecv)) { QXmppStreamManagementEnabled streamManagementEnabled; @@ -735,7 +735,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) d->streamManagementEnabled = true; enableStreamManagement(true); // we are connected now - emit connected(); + Q_EMIT connected(); } else if (QXmppStreamManagementResumed::isStreamManagementResumed(nodeRecv)) { QXmppStreamManagementResumed streamManagementResumed; streamManagementResumed.parse(nodeRecv); @@ -747,7 +747,7 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) enableStreamManagement(false); // we are connected now // TODO: The stream was resumed. Therefore, we should not send presence information or request the roster. - emit connected(); + Q_EMIT connected(); } else if (QXmppStreamManagementFailed::isStreamManagementFailed(nodeRecv)) { if (d->isResuming) { // resuming failed. We can try to bind a resource now. @@ -767,10 +767,10 @@ void QXmppOutgoingClient::handleStanza(const QDomElement &nodeRecv) // otherwise we are done d->sessionStarted = true; - emit connected(); + Q_EMIT connected(); } else { // we are connected now, but stream management is disabled - emit connected(); + Q_EMIT connected(); } } } @@ -812,7 +812,7 @@ void QXmppOutgoingClient::pingTimeout() { warning("Ping timeout"); QXmppStream::disconnectFromHost(); - emit error(QXmppClient::KeepAliveError); + Q_EMIT error(QXmppClient::KeepAliveError); } bool QXmppOutgoingClient::setResumeAddress(const QString &address) diff --git a/src/client/QXmppRegistrationManager.cpp b/src/client/QXmppRegistrationManager.cpp index 71c2f39e..b4ae7510 100644 --- a/src/client/QXmppRegistrationManager.cpp +++ b/src/client/QXmppRegistrationManager.cpp @@ -183,9 +183,9 @@ bool QXmppRegistrationManager::handleStanza(const QDomElement &stanza) if (features.registerMode() == QXmppStreamFeatures::Disabled) { warning(QStringLiteral("Could not request the registration form, because the server does not advertise the register stream feature.")); client()->disconnectFromServer(); - emit registrationFailed({ QXmppStanza::Error::Cancel, - QXmppStanza::Error::FeatureNotImplemented, - QStringLiteral("The server does not advertise the register stream feature.") }); + Q_EMIT registrationFailed({ QXmppStanza::Error::Cancel, + QXmppStanza::Error::FeatureNotImplemented, + QStringLiteral("The server does not advertise the register stream feature.") }); return true; } @@ -210,11 +210,11 @@ bool QXmppRegistrationManager::handleStanza(const QDomElement &stanza) switch (iq.type()) { case QXmppIq::Result: info(QStringLiteral("Successfully registered with the service.")); - emit registrationSucceeded(); + Q_EMIT registrationSucceeded(); break; case QXmppIq::Error: warning(QStringLiteral("Registering with the service failed: ").append(iq.error().text())); - emit registrationFailed(iq.error()); + Q_EMIT registrationFailed(iq.error()); break; default: break; // should never occur @@ -230,11 +230,11 @@ bool QXmppRegistrationManager::handleStanza(const QDomElement &stanza) case QXmppIq::Result: info(QStringLiteral("Changed password successfully.")); client()->configuration().setPassword(d->newPassword); - emit passwordChanged(d->newPassword); + Q_EMIT passwordChanged(d->newPassword); break; case QXmppIq::Error: warning(QStringLiteral("Failed to change password: ").append(iq.error().text())); - emit passwordChangeFailed(iq.error()); + Q_EMIT passwordChangeFailed(iq.error()); break; default: break; // should never occur @@ -250,12 +250,12 @@ bool QXmppRegistrationManager::handleStanza(const QDomElement &stanza) switch (iq.type()) { case QXmppIq::Result: info(QStringLiteral("Account deleted successfully.")); - emit accountDeleted(); + Q_EMIT accountDeleted(); client()->disconnectFromServer(); break; case QXmppIq::Error: warning(QStringLiteral("Failed to delete account: ").append(iq.error().text())); - emit accountDeletionFailed(iq.error()); + Q_EMIT accountDeletionFailed(iq.error()); break; default: break; // should never occur @@ -267,7 +267,7 @@ bool QXmppRegistrationManager::handleStanza(const QDomElement &stanza) QXmppRegisterIq iq; iq.parse(stanza); - emit registrationFormReceived(iq); + Q_EMIT registrationFormReceived(iq); } } return false; @@ -302,6 +302,6 @@ void QXmppRegistrationManager::setSupportedByServer(bool registrationSupported) { if (d->supportedByServer != registrationSupported) { d->supportedByServer = registrationSupported; - emit supportedByServerChanged(); + Q_EMIT supportedByServerChanged(); } } diff --git a/src/client/QXmppRemoteMethod.cpp b/src/client/QXmppRemoteMethod.cpp index 71a48bdd..7a282647 100644 --- a/src/client/QXmppRemoteMethod.cpp +++ b/src/client/QXmppRemoteMethod.cpp @@ -39,7 +39,7 @@ void QXmppRemoteMethod::gotError(const QXmppRpcErrorIq &iq) m_result.hasError = true; m_result.errorMessage = iq.error().text(); m_result.code = iq.error().type(); - emit callDone(); + Q_EMIT callDone(); } } @@ -50,6 +50,6 @@ void QXmppRemoteMethod::gotResult(const QXmppRpcResponseIq &iq) // FIXME: we don't handle multiple responses const auto values = iq.values(); m_result.result = values.first(); - emit callDone(); + Q_EMIT callDone(); } } diff --git a/src/client/QXmppRosterManager.cpp b/src/client/QXmppRosterManager.cpp index bb4eb435..810a4615 100644 --- a/src/client/QXmppRosterManager.cpp +++ b/src/client/QXmppRosterManager.cpp @@ -173,17 +173,17 @@ bool QXmppRosterManager::handleStanza(const QDomElement &element) if (item.subscriptionType() == QXmppRosterIq::Item::Remove) { if (d->entries.remove(bareJid)) { // notify the user that the item was removed - emit itemRemoved(bareJid); + Q_EMIT itemRemoved(bareJid); } } else { const bool added = !d->entries.contains(bareJid); d->entries.insert(bareJid, item); if (added) { // notify the user that the item was added - emit itemAdded(bareJid); + Q_EMIT itemAdded(bareJid); } else { // notify the user that the item changed - emit itemChanged(bareJid); + Q_EMIT itemChanged(bareJid); } } } @@ -196,7 +196,7 @@ bool QXmppRosterManager::handleStanza(const QDomElement &element) } if (isInitial) { d->isRosterReceived = true; - emit rosterReceived(); + Q_EMIT rosterReceived(); } break; } @@ -221,11 +221,11 @@ void QXmppRosterManager::_q_presenceReceived(const QXmppPresence &presence) switch (presence.type()) { case QXmppPresence::Available: d->presences[bareJid][resource] = presence; - emit presenceChanged(bareJid, resource); + Q_EMIT presenceChanged(bareJid, resource); break; case QXmppPresence::Unavailable: d->presences[bareJid].remove(resource); - emit presenceChanged(bareJid, resource); + Q_EMIT presenceChanged(bareJid, resource); break; case QXmppPresence::Subscribe: if (client()->configuration().autoAcceptSubscriptions()) { @@ -235,8 +235,8 @@ void QXmppRosterManager::_q_presenceReceived(const QXmppPresence &presence) // ask for reciprocal subscription subscribe(bareJid); } else { - emit subscriptionReceived(bareJid); - emit subscriptionRequestReceived(bareJid, presence); + Q_EMIT subscriptionReceived(bareJid); + Q_EMIT subscriptionRequestReceived(bareJid, presence); } break; default: diff --git a/src/client/QXmppRpcManager.cpp b/src/client/QXmppRpcManager.cpp index 2d92f314..c72a9563 100644 --- a/src/client/QXmppRpcManager.cpp +++ b/src/client/QXmppRpcManager.cpp @@ -162,12 +162,12 @@ bool QXmppRpcManager::handleStanza(const QDomElement &element) } else if (QXmppRpcResponseIq::isRpcResponseIq(element)) { QXmppRpcResponseIq rpcResponseIq; rpcResponseIq.parse(element); - emit rpcCallResponse(rpcResponseIq); + Q_EMIT rpcCallResponse(rpcResponseIq); return true; } else if (QXmppRpcErrorIq::isRpcErrorIq(element)) { QXmppRpcErrorIq rpcErrorIq; rpcErrorIq.parse(element); - emit rpcCallError(rpcErrorIq); + Q_EMIT rpcCallError(rpcErrorIq); return true; } return false; diff --git a/src/client/QXmppTransferManager.cpp b/src/client/QXmppTransferManager.cpp index ac138986..c4936323 100644 --- a/src/client/QXmppTransferManager.cpp +++ b/src/client/QXmppTransferManager.cpp @@ -339,7 +339,7 @@ void QXmppTransferJob::setLocalFileUrl(const QUrl &localFileUrl) { if (localFileUrl != d->localFileUrl) { d->localFileUrl = localFileUrl; - emit localFileUrlChanged(localFileUrl); + Q_EMIT localFileUrlChanged(localFileUrl); } } @@ -412,17 +412,17 @@ void QXmppTransferJob::setState(QXmppTransferJob::State state) if (d->state == QXmppTransferJob::TransferState) { d->transferStart.start(); } - emit stateChanged(d->state); + Q_EMIT stateChanged(d->state); } } void QXmppTransferJob::_q_terminated() { - emit stateChanged(d->state); + Q_EMIT stateChanged(d->state); if (d->error != NoError) { - emit error(d->error); + Q_EMIT error(d->error); } - emit finished(); + Q_EMIT finished(); } void QXmppTransferJob::terminate(QXmppTransferJob::Error cause) @@ -528,7 +528,7 @@ bool QXmppTransferIncomingJob::writeData(const QByteArray &data) if (!d->fileInfo.hash().isEmpty()) { d->hash.addData(data); } - emit progress(d->done, d->fileInfo.size()); + Q_EMIT progress(d->done, d->fileInfo.size()); return true; } @@ -688,7 +688,7 @@ void QXmppTransferOutgoingJob::_q_sendData() d->socksSocket->write(buffer, length); delete[] buffer; d->done += length; - emit progress(d->done, fileSize()); + Q_EMIT progress(d->done, fileSize()); } } /// \endcond @@ -1073,7 +1073,7 @@ void QXmppTransferManager::ibbResponseReceived(const QXmppIq &iq) client()->sendPacket(dataIq); job->d->done += buffer.size(); - emit job->progress(job->d->done, job->fileSize()); + Q_EMIT job->progress(job->d->done, job->fileSize()); } else { // close the bytestream QXmppIbbCloseIq closeIq; @@ -1173,7 +1173,7 @@ void QXmppTransferManager::_q_jobFinished() return; } - emit jobFinished(job); + Q_EMIT jobFinished(job); } void QXmppTransferManager::_q_jobStateChanged(QXmppTransferJob::State state) @@ -1232,7 +1232,7 @@ void QXmppTransferManager::_q_jobStateChanged(QXmppTransferJob::State state) client()->sendPacket(response); // notify user - emit jobStarted(job); + Q_EMIT jobStarted(job); } /// @@ -1355,7 +1355,7 @@ QXmppTransferJob *QXmppTransferManager::sendFile(const QString &jid, QIODevice * client()->sendPacket(request); // notify user - emit jobStarted(job); + Q_EMIT jobStarted(job); return job; } @@ -1559,7 +1559,7 @@ void QXmppTransferManager::streamInitiationSetReceived(const QXmppStreamInitiati connect(job, &QXmppTransferJob::stateChanged, this, &QXmppTransferManager::_q_jobStateChanged); // allow user to accept or decline the job - emit fileReceived(job); + Q_EMIT fileReceived(job); } QString QXmppTransferManager::proxy() const diff --git a/src/client/QXmppTrustManager.cpp b/src/client/QXmppTrustManager.cpp index 2a5a591b..a5031a52 100644 --- a/src/client/QXmppTrustManager.cpp +++ b/src/client/QXmppTrustManager.cpp @@ -212,7 +212,7 @@ QFuture<void> QXmppTrustManager::setTrustLevel(const QString &encryption, const auto future = m_trustStorage->setTrustLevel(encryption, keyIds, trustLevel); await(future, this, [=](QHash<QString, QMultiHash<QString, QByteArray>> modifiedKeys) mutable { - emit trustLevelsChanged(modifiedKeys); + Q_EMIT trustLevelsChanged(modifiedKeys); interface.reportFinished(); }); @@ -233,7 +233,7 @@ QFuture<void> QXmppTrustManager::setTrustLevel(const QString &encryption, const auto future = m_trustStorage->setTrustLevel(encryption, keyOwnerJids, oldTrustLevel, newTrustLevel); await(future, this, [=](QHash<QString, QMultiHash<QString, QByteArray>> modifiedKeys) mutable { - emit trustLevelsChanged(modifiedKeys); + Q_EMIT trustLevelsChanged(modifiedKeys); interface.reportFinished(); }); diff --git a/src/client/QXmppUploadRequestManager.cpp b/src/client/QXmppUploadRequestManager.cpp index e40233ae..17a58893 100644 --- a/src/client/QXmppUploadRequestManager.cpp +++ b/src/client/QXmppUploadRequestManager.cpp @@ -275,13 +275,13 @@ bool QXmppUploadRequestManager::handleStanza(const QDomElement &element) QXmppHttpUploadSlotIq slot; slot.parse(element); - emit slotReceived(slot); + Q_EMIT slotReceived(slot); return true; } else if (QXmppHttpUploadRequestIq::isHttpUploadRequestIq(element)) { QXmppHttpUploadRequestIq requestError; requestError.parse(element); - emit requestFailed(requestError); + Q_EMIT requestFailed(requestError); return true; } return false; @@ -312,7 +312,7 @@ void QXmppUploadRequestManager::handleDiscoInfo(const QXmppDiscoveryIq &iq) } d->uploadServices.append(service); - emit serviceFoundChanged(); + Q_EMIT serviceFoundChanged(); } } return; @@ -331,7 +331,7 @@ void QXmppUploadRequestManager::setClient(QXmppClient *client) // on client disconnect remove all upload services connect(client, &QXmppClient::disconnected, this, [this]() { d->uploadServices.clear(); - emit serviceFoundChanged(); + Q_EMIT serviceFoundChanged(); }); } } diff --git a/src/client/QXmppVCardManager.cpp b/src/client/QXmppVCardManager.cpp index fa5a5f02..78d23d7d 100644 --- a/src/client/QXmppVCardManager.cpp +++ b/src/client/QXmppVCardManager.cpp @@ -95,10 +95,10 @@ bool QXmppVCardManager::handleStanza(const QDomElement &element) if (vCardIq.from().isEmpty() || vCardIq.from() == client()->configuration().jidBare()) { d->clientVCard = vCardIq; d->isClientVCardReceived = true; - emit clientVCardReceived(); + Q_EMIT clientVCardReceived(); } - emit vCardReceived(vCardIq); + Q_EMIT vCardReceived(vCardIq); return true; } diff --git a/src/client/QXmppVersionManager.cpp b/src/client/QXmppVersionManager.cpp index f4cabbdc..4d12db5d 100644 --- a/src/client/QXmppVersionManager.cpp +++ b/src/client/QXmppVersionManager.cpp @@ -132,7 +132,7 @@ bool QXmppVersionManager::handleStanza(const QDomElement &element) if (versionIq.type() == QXmppIq::Result) { // emit response - emit versionReceived(versionIq); + Q_EMIT versionReceived(versionIq); } return true; |
