QXmppStanza::Error: Use std::optional<> internally

This makes the variables for the error type and condition an
std::optional<> as this makes the meaning clearer than hidden -1 values
created by dubious casts.

For now, the API is not changed, because we can't replace the getter
easily. We could do something like type() and optionalType().

1 files changed, 0 insertions, 6 deletions

diff --git a/src/base/QXmppStanza.h b/src/base/QXmppStanza.h
index caf6d6df..03a0680b 100644
--- a/src/base/QXmppStanza.h
+++ b/src/base/QXmppStanza.h
@@ -190,12 +190,6 @@ public:
         /// \endcond
 
     private:
-        QString getConditionStr() const;
-        void setConditionFromStr(const QString &cond);
-
-        QString getTypeStr() const;
-        void setTypeFromStr(const QString &type);
-
         QSharedDataPointer<QXmppStanzaErrorPrivate> d;
     };