From d1978692b8cde1e5d785e31e4d443ae7a52f143f Mon Sep 17 00:00:00 2001 From: Linus Jahn Date: Sat, 11 Jul 2020 22:36:38 +0200 Subject: QXmppStanza::Error: Use std::optional<> internally This makes the variables for the error type and condition an std::optional<> as this makes the meaning clearer than hidden -1 values created by dubious casts. For now, the API is not changed, because we can't replace the getter easily. We could do something like type() and optionalType(). --- src/base/QXmppStanza.h | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/base/QXmppStanza.h') diff --git a/src/base/QXmppStanza.h b/src/base/QXmppStanza.h index caf6d6df..03a0680b 100644 --- a/src/base/QXmppStanza.h +++ b/src/base/QXmppStanza.h @@ -190,12 +190,6 @@ public: /// \endcond private: - QString getConditionStr() const; - void setConditionFromStr(const QString &cond); - - QString getTypeStr() const; - void setTypeFromStr(const QString &type); - QSharedDataPointer d; }; -- cgit v1.2.3