improve SASL stanza test coverage

2 files changed, 56 insertions, 0 deletions

diff --git a/tests/sasl.cpp b/tests/sasl.cpp
index 46f5f22b..e874e120 100644
--- a/tests/sasl.cpp
+++ b/tests/sasl.cpp
@@ -74,6 +74,32 @@ void tst_QXmppSasl::testAuth()
     serializePacket(auth, xml);
 }
 
+void tst_QXmppSasl::testChallenge_data()
+{
+    QTest::addColumn<QByteArray>("xml");
+    QTest::addColumn<QByteArray>("value");
+
+    QTest::newRow("empty")
+        << QByteArray("<challenge xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\"/>")
+        << QByteArray();
+
+    QTest::newRow("value")
+        << QByteArray("<challenge xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\">AGZvbwBiYXI=</challenge>")
+        << QByteArray("\0foo\0bar", 8);
+}
+
+void tst_QXmppSasl::testChallenge()
+{
+    QFETCH(QByteArray, xml);
+    QFETCH(QByteArray, value);
+
+    // no condition
+    QXmppSaslChallenge challenge;
+    parsePacket(challenge, xml);
+    QCOMPARE(challenge.value(), value);
+    serializePacket(challenge, xml);
+}
+
 void tst_QXmppSasl::testFailure()
 {
     // no condition
@@ -91,6 +117,32 @@ void tst_QXmppSasl::testFailure()
     serializePacket(failure2, xml2);
 }
 
+void tst_QXmppSasl::testResponse_data()
+{
+    QTest::addColumn<QByteArray>("xml");
+    QTest::addColumn<QByteArray>("value");
+
+    QTest::newRow("empty")
+        << QByteArray("<response xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\"/>")
+        << QByteArray();
+
+    QTest::newRow("value")
+        << QByteArray("<response xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\">AGZvbwBiYXI=</response>")
+        << QByteArray("\0foo\0bar", 8);
+}
+
+void tst_QXmppSasl::testResponse()
+{
+    QFETCH(QByteArray, xml);
+    QFETCH(QByteArray, value);
+
+    // no condition
+    QXmppSaslResponse response;
+    parsePacket(response, xml);
+    QCOMPARE(response.value(), value);
+    serializePacket(response, xml);
+}
+
 void tst_QXmppSasl::testSuccess()
 {
     const QByteArray xml = "<success xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\"/>";
diff --git a/tests/sasl.h b/tests/sasl.h
index 5271fbbb..7b5dd221 100644
--- a/tests/sasl.h
+++ b/tests/sasl.h
@@ -31,7 +31,11 @@ private slots:
     void testParsing();
     void testAuth_data();
     void testAuth();
+    void testChallenge_data();
+    void testChallenge();
     void testFailure();
+    void testResponse_data();
+    void testResponse();
     void testSuccess();
 };