SceEnvelope: Don't use reference to avoid misusage

2 files changed, 4 insertions, 5 deletions

diff --git a/src/client/QXmppSceEnvelope_p.h b/src/client/QXmppSceEnvelope_p.h
index 4a92378d..b40da9fd 100644
--- a/src/client/QXmppSceEnvelope_p.h
+++ b/src/client/QXmppSceEnvelope_p.h
@@ -25,8 +25,8 @@
 class QXmppSceEnvelopeReader
 {
 public:
-    QXmppSceEnvelopeReader(const QDomElement &element)
-        : element(element)
+    QXmppSceEnvelopeReader(QDomElement &&element)
+        : element(std::move(element))
     {
     }
 
@@ -51,7 +51,7 @@ public:
     // rpad is usually not needed (but can be parsed manually if really needed)
 
 private:
-    const QDomElement &element;
+    QDomElement element;
 };
 
 class QXmppSceEnvelopeWriter
diff --git a/tests/qxmppsceenvelope/tst_qxmppsceenvelope.cpp b/tests/qxmppsceenvelope/tst_qxmppsceenvelope.cpp
index a490a5c0..30c6d493 100644
--- a/tests/qxmppsceenvelope/tst_qxmppsceenvelope.cpp
+++ b/tests/qxmppsceenvelope/tst_qxmppsceenvelope.cpp
@@ -26,9 +26,8 @@ void tst_QXmppSceEnvelope::testReader()
         "<from jid=\"opportunity@mars.planet\"/>"
         "<rpad>C1DHN9HK-9A25tSmwK4hU!Jji9%GKYK^syIlHJT9TnI4</rpad>"
         "</envelope>");
-    const auto dom = xmlToDom(xml);
 
-    QXmppSceEnvelopeReader reader(dom);
+    QXmppSceEnvelopeReader reader(xmlToDom(xml));
     QCOMPARE(reader.from(), QStringLiteral("opportunity@mars.planet"));
     QCOMPARE(reader.to(), QStringLiteral("missioncontrol@houston.nasa.gov"));
     QCOMPARE(reader.timestamp(), QDateTime({ 2004, 01, 25 }, { 05, 05, 00 }, Qt::UTC));