only emit message if logging type is "SIGNAL"

2 files changed, 6 insertions, 10 deletions

diff --git a/source/QXmppLogger.cpp b/source/QXmppLogger.cpp
index dc34a36d..d67ff047 100644
--- a/source/QXmppLogger.cpp
+++ b/source/QXmppLogger.cpp
@@ -79,7 +79,6 @@ QXmppLogger::LoggingType QXmppLogger::loggingType()
 
 void QXmppLogger::log(QXmppLogger::MessageType type, const QString& str)
 {
-    bool emitMessageSignal = true;
     switch(m_loggingType)
     {
     case QXmppLogger::FILE:
@@ -95,15 +94,12 @@ void QXmppLogger::log(QXmppLogger::MessageType type, const QString& str)
     case QXmppLogger::STDOUT:
         std::cout << typeName(type) << " " << qPrintable(str) << std::endl;
         break;
-    case QXmppLogger::SIGNALONLY:
-        emitMessageSignal = true;
+    case QXmppLogger::SIGNAL:
+        emit message(type, str);
         break;
     default:
-        emitMessageSignal = false;
         break;
     }
-    if(emitMessageSignal)
-        emit message(type, str);
 }
 
 QXmppLogger::LoggingType QXmppLogger::getLoggingType()
diff --git a/source/QXmppLogger.h b/source/QXmppLogger.h
index cf8f9290..0629e1fe 100644
--- a/source/QXmppLogger.h
+++ b/source/QXmppLogger.h
@@ -34,10 +34,10 @@ class QXmppLogger : public QObject
 public:
     enum LoggingType
     {
-        NONE = 0,
-        FILE,
-        STDOUT,
-        SIGNALONLY
+        NONE = 0, ///< Log messages are discarded
+        FILE,     ///< Log messages are written to a file
+        STDOUT,   ///< Log messages are written to the standard output
+        SIGNAL,   ///< Log messages are emitted as a signal
     };
 
     enum MessageType