diff options
| author | Karol Kosek <krkk@krkk.ct8.pl> | 2020-12-30 17:34:12 +0100 |
|---|---|---|
| committer | Felix Queißner <felix@ib-queissner.de> | 2020-12-30 20:31:39 +0100 |
| commit | cf4568bb5d5d6d098e411461c28b832908e965a7 (patch) | |
| tree | 6c629e655278d4f9e2bc9cade34d8f8611bd1134 /src | |
| parent | 91e3729fe67cd7bd645c9babbbfe11ea31ad7229 (diff) | |
| download | kristall-cf4568bb5d5d6d098e411461c28b832908e965a7.tar.gz | |
Use const variables
Diffstat (limited to 'src')
| -rw-r--r-- | src/dialogs/certificateiodialog.cpp | 4 | ||||
| -rw-r--r-- | src/dialogs/newidentitiydialog.cpp | 2 | ||||
| -rw-r--r-- | src/identitycollection.cpp | 2 | ||||
| -rw-r--r-- | src/main.cpp | 2 | ||||
| -rw-r--r-- | src/trustedhostcollection.cpp | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/src/dialogs/certificateiodialog.cpp b/src/dialogs/certificateiodialog.cpp index 8c9fcd5..079d793 100644 --- a/src/dialogs/certificateiodialog.cpp +++ b/src/dialogs/certificateiodialog.cpp @@ -72,7 +72,7 @@ void CertificateIoDialog::on_select_certificate_file_button_clicked() if(dialog.exec() != QDialog::Accepted) return; - this->ui->certificate_file_name->setText(dialog.selectedFiles().first()); + this->ui->certificate_file_name->setText(dialog.selectedFiles().constFirst()); this->updateUI(); } @@ -88,7 +88,7 @@ void CertificateIoDialog::on_select_key_file_button_clicked() if(dialog.exec() != QDialog::Accepted) return; - this->ui->key_file_name->setText(dialog.selectedFiles().first()); + this->ui->key_file_name->setText(dialog.selectedFiles().constFirst()); this->updateUI(); } diff --git a/src/dialogs/newidentitiydialog.cpp b/src/dialogs/newidentitiydialog.cpp index 30e0cc6..aa2241c 100644 --- a/src/dialogs/newidentitiydialog.cpp +++ b/src/dialogs/newidentitiydialog.cpp @@ -19,7 +19,7 @@ NewIdentitiyDialog::NewIdentitiyDialog(QWidget *parent) : ui->expiration_date->setTime(QTime(12, 00)); ui->group->clear(); - for(auto group_name : kristall::identities.groups()) + for(const auto &group_name : kristall::identities.groups()) { ui->group->addItem(group_name); } diff --git a/src/identitycollection.cpp b/src/identitycollection.cpp index 45a86a7..7ec02d6 100644 --- a/src/identitycollection.cpp +++ b/src/identitycollection.cpp @@ -106,7 +106,7 @@ void IdentityCollection::load(QSettings &settings) id->identity.certificate = QSslCertificate::fromData( settings.value("certificate").toByteArray(), QSsl::Der - ).first(); + ).constFirst(); id->identity.private_key = QSslKey( settings.value("private_key").toByteArray(), diff --git a/src/main.cpp b/src/main.cpp index c7b6259..3daeb95 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -272,7 +272,7 @@ int main(int argc, char *argv[]) auto urls = cli_parser.positionalArguments(); if(urls.size() > 0) { - for(auto url_str : urls) { + for(const auto &url_str : urls) { QUrl url { url_str }; if (url.isRelative()) { if (QFile::exists(url_str)) { diff --git a/src/trustedhostcollection.cpp b/src/trustedhostcollection.cpp index 57a45df..5171fd3 100644 --- a/src/trustedhostcollection.cpp +++ b/src/trustedhostcollection.cpp @@ -104,7 +104,7 @@ void TrustedHostCollection::clear() bool TrustedHostCollection::insert(const TrustedHost &host) { - for(auto const & item : items) + for(auto const & item : qAsConst(items)) { if(item.host_name == host.host_name) return false; |