Fixes warnings and compile errors that didn't trigger without recomple.

6 files changed, 14 insertions, 3 deletions

diff --git a/src/certificatemanagementdialog.cpp b/src/certificatemanagementdialog.cpp
index f1f1453..a14a9a4 100644
--- a/src/certificatemanagementdialog.cpp
+++ b/src/certificatemanagementdialog.cpp
@@ -81,6 +81,7 @@ void CertificateManagementDialog::on_cert_notes_textChanged()
 
 void CertificateManagementDialog::on_cert_display_name_textChanged(const QString &arg1)
 {
+    Q_UNUSED(arg1)
     if(this->selected_identity != nullptr) {
         this->selected_identity->display_name = this->ui->cert_display_name->text();
     }
diff --git a/src/certificateselectiondialog.cpp b/src/certificateselectiondialog.cpp
index 280b5db..f4dab38 100644
--- a/src/certificateselectiondialog.cpp
+++ b/src/certificateselectiondialog.cpp
@@ -84,6 +84,8 @@ void CertificateSelectionDialog::acceptTemporaryWithTimeout(QDateTime timeout)
 
 void CertificateSelectionDialog::on_currentChanged(const QModelIndex &current, const QModelIndex &previous)
 {
+    Q_UNUSED(current)
+    Q_UNUSED(previous)
     auto id = global_identities.getIdentity(current);
 
     this->ui->use_selected_cert->setEnabled(id.isValid());
diff --git a/src/elidelabel.cpp b/src/elidelabel.cpp
index 8830f69..60329b1 100644
--- a/src/elidelabel.cpp
+++ b/src/elidelabel.cpp
@@ -47,7 +47,7 @@ QSize ElideLabel::minimumSizeHint() const
     if (m_elideMode != Qt::ElideNone)
     {
         const QFontMetrics& fm = fontMetrics();
-        QSize size(fm.width("..."), fm.height());
+        QSize size(fm.horizontalAdvance("..."), fm.height());
         return size;
     }
 
diff --git a/src/favouritecollection.cpp b/src/favouritecollection.cpp
index 161eacf..7b9bec5 100644
--- a/src/favouritecollection.cpp
+++ b/src/favouritecollection.cpp
@@ -122,11 +122,15 @@ bool FavouriteCollection::load(QSettings & settings)
 
 int FavouriteCollection::rowCount(const QModelIndex &parent) const
 {
+    Q_UNUSED(parent)
     return items.size();
 }
 
 bool FavouriteCollection::setData(const QModelIndex &index, const QVariant &value, int role)
 {
+    Q_UNUSED(value)
+    Q_UNUSED(index)
+    Q_UNUSED(role)
     return false;
 }
 
diff --git a/src/filehandler.cpp b/src/filehandler.cpp
index a3012ba..a8e2e24 100644
--- a/src/filehandler.cpp
+++ b/src/filehandler.cpp
@@ -34,10 +34,10 @@ bool FileHandler::startRequest(const QUrl &url)
 
 bool FileHandler::isInProgress() const
 {
-
+    return false;
 }
 
 bool FileHandler::cancelRequest()
 {
-
+    return true;
 }
diff --git a/src/tabbrowsinghistory.cpp b/src/tabbrowsinghistory.cpp
index 435bca7..db4a981 100644
--- a/src/tabbrowsinghistory.cpp
+++ b/src/tabbrowsinghistory.cpp
@@ -61,11 +61,15 @@ QModelIndex TabBrowsingHistory::oneBackward(QModelIndex index) const
 
 int TabBrowsingHistory::rowCount(const QModelIndex &parent) const
 {
+    Q_UNUSED(parent)
     return history.size();
 }
 
 bool TabBrowsingHistory::setData(const QModelIndex &index, const QVariant &value, int role)
 {
+    Q_UNUSED(index)
+    Q_UNUSED(value)
+    Q_UNUSED(role)
     return false;
 }