aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorJP Abgrall <jpa@google.com>2014-12-16 19:03:31 -0800
committerMoyster <oysterized@gmail.com>2016-09-28 15:15:59 +0200
commitee7803818628514b94725610612d643e3e5b3b91 (patch)
tree6f994352ff703f28fe07df6b50cbba3d13f28a8a /net
parent87f22c44bb5c7b917143b7ea1f9fbda198c11fd4 (diff)
netfilter: IDLETIMER: fix invalid deference of timer
"timer" was checked for null, but used later without being re-checked. Change-Id: Ib4d08cd49860c9f157d1cac556705ba85cd44f4e Reported-by: dan.carpenter@oracle.com Signed-off-by: JP Abgrall <jpa@google.com> Signed-off-by: engstk <eng.stk@sapo.pt>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/xt_IDLETIMER.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c
index f6562ba97..ed6956668 100644
--- a/net/netfilter/xt_IDLETIMER.c
+++ b/net/netfilter/xt_IDLETIMER.c
@@ -188,7 +188,7 @@ static ssize_t idletimer_tg_show(struct kobject *kobj, struct attribute *attr,
return sprintf(buf, "%u\n",
jiffies_to_msecs(expires - now) / 1000);
- if (timer->send_nl_msg)
+ if (timer && timer->send_nl_msg)
return sprintf(buf, "0 %d\n",
jiffies_to_msecs(now - expires) / 1000);
else