aboutsummaryrefslogtreecommitdiff
path: root/net/core
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-01-26 13:08:10 -0500
committerMister Oyster <oysterized@gmail.com>2017-07-04 12:11:24 +0200
commit814ba889fd64fd1eb7c2a0a4bed33ee075c8b54a (patch)
tree8fe92e244dc8836304f7ce8864de2e5ec20ab687 /net/core
parent1025ae585e4366ce865ee30da88563931c6ef128 (diff)
gfs2: avoid uninitialized variable warning
commit 67893f12e5374bbcaaffbc6e570acbc2714ea884 upstream. We get a bogus warning about a potential uninitialized variable use in gfs2, because the compiler does not figure out that we never use the leaf number if get_leaf_nr() returns an error: fs/gfs2/dir.c: In function 'get_first_leaf': fs/gfs2/dir.c:802:9: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized] fs/gfs2/dir.c: In function 'dir_split_leaf': fs/gfs2/dir.c:1021:8: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized] Changing the 'if (!error)' to 'if (!IS_ERR_VALUE(error))' is sufficient to let gcc understand that this is exactly the same condition as in IS_ERR() so it can optimize the code path enough to understand it. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions