diff options
| author | Tejun Heo <tj@kernel.org> | 2014-09-08 08:03:58 +0900 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-09-13 13:35:19 +0200 |
| commit | 6af0cab8fa04cfe9fb99f244171116f9a7a18e4d (patch) | |
| tree | de35183aaba6b7444a4a278161e65a3f31660079 /mm | |
| parent | c6d4531c0e9f64beec07fa8eea53bdfc33d2515c (diff) | |
bdi: remove bdi->wb_lock locking around bdi->dev clearing in bdi_unregister()
The only places where NULL test on bdi->dev is used are
bdi_[un]register(). The functions can't be called in parallel anyway
and there's no point in protecting bdi->dev clearing with a lock.
Remove bdi->wb_lock grabbing around bdi->dev clearing and move it
after device_unregister() call so that bdi->dev doesn't have to be
cached in a local variable.
This patch shouldn't introduce any behavior difference.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/backing-dev.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/mm/backing-dev.c b/mm/backing-dev.c index eea1a9dfa..2a05c2642 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -401,21 +401,15 @@ static void bdi_prune_sb(struct backing_dev_info *bdi) void bdi_unregister(struct backing_dev_info *bdi) { - struct device *dev = bdi->dev; - - if (dev) { + if (bdi->dev) { bdi_set_min_ratio(bdi, 0); trace_writeback_bdi_unregister(bdi); bdi_prune_sb(bdi); bdi_wb_shutdown(bdi); bdi_debug_unregister(bdi); - - spin_lock_bh(&bdi->wb_lock); + device_unregister(bdi->dev); bdi->dev = NULL; - spin_unlock_bh(&bdi->wb_lock); - - device_unregister(dev); } } EXPORT_SYMBOL(bdi_unregister); |