diff options
| author | Michal Hocko <mhocko@suse.cz> | 2015-02-11 15:26:15 -0800 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2019-05-02 19:08:01 +0200 |
| commit | 32c058d52df73f6fc087c4fb143d29904d95eb62 (patch) | |
| tree | d3efa9897f53548e34e9affb880d9b9e178c53d9 /mm | |
| parent | f5b67d273819a8079da116bb74980c76051d2b74 (diff) | |
oom: thaw the OOM victim if it is frozen
oom_kill_process only sets TIF_MEMDIE flag and sends a signal to the
victim. This is basically noop when the task is frozen though because the
task sleeps in the uninterruptible sleep. The victim is eventually thawed
later when oom_scan_process_thread meets the task again in a later OOM
invocation so the OOM killer doesn't live lock. But this is less than
optimal.
Let's add __thaw_task into mark_tsk_oom_victim after we set TIF_MEMDIE to
the victim. We are not checking whether the task is frozen because that
would be racy and __thaw_task does that already. oom_scan_process_thread
doesn't need to care about freezer anymore as TIF_MEMDIE and freezer are
excluded completely now.
Change-Id: I0e1e58f06dab168d2e94f2b475e93763e73101ec
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Tejun Heo <tj@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/oom_kill.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 6c19a8307..ad8afb380 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -278,8 +278,6 @@ enum oom_scan_t oom_scan_process_thread(struct task_struct *task, * someone new to kill. */ if (test_tsk_thread_flag(task, TIF_MEMDIE)) { - if (unlikely(frozen(task))) - __thaw_task(task); if (!force_kill) { if (time_after(jiffies, last_victim + msecs_to_jiffies(100))) { @@ -440,6 +438,14 @@ void note_oom_kill(void) void mark_tsk_oom_victim(struct task_struct *tsk) { set_tsk_thread_flag(tsk, TIF_MEMDIE); + + /* + * Make sure that the task is woken up from uninterruptible sleep + * if it is frozen because OOM killer wouldn't be able to free + * any memory and livelock. freezing_slow_path will tell the freezer + * that TIF_MEMDIE tasks should be ignored. + */ + __thaw_task(tsk); } /** |