diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-03-20 16:15:24 -0500 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2019-09-11 14:26:36 +0200 |
| commit | 26925894221e73d1b4f0d93d1b0cadfbce41a917 (patch) | |
| tree | c91b559921c7660adfd69b77d29ec6a48fd1e7b2 /kernel | |
| parent | c11a9346cfa7de34444873677ba7b02ab6df25d6 (diff) | |
ALSA: rawmidi: Fix potential Spectre v1 vulnerability
commit 2b1d9c8f87235f593826b9cf46ec10247741fff9 upstream.
info->stream is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
sound/core/rawmidi.c:604 __snd_rawmidi_info_select() warn: potential spectre issue 'rmidi->streams' [r] (local cap)
Fix this by sanitizing info->stream before using it to index
rmidi->streams.
Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].
[1] https://lore.kernel.org/lkml/20180423164740.GY17484@dhcp22.suse.cz/
Change-Id: I2c8b93b82ad4374027a03dc4c73fdf74eee696e6
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions