diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-08-30 16:30:35 +0300 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2017-11-06 15:34:17 +0100 |
| commit | 580244fcb9427bbd7ecc5b09040d16b4b0e9fbc6 (patch) | |
| tree | fceca502cfc62f1ce461161bc9a672bf9d3cbd07 /kernel/trace/trace.c | |
| parent | be81d52b3faa4a611c06ef8c39902ead00cf1740 (diff) | |
scsi: qla2xxx: Fix an integer overflow in sysfs code
commit e6f77540c067b48dee10f1e33678415bfcc89017 upstream.
The value of "size" comes from the user. When we add "start + size" it
could lead to an integer overflow bug.
It means we vmalloc() a lot more memory than we had intended. I believe
that on 64 bit systems vmalloc() can succeed even if we ask it to
allocate huge 4GB buffers. So we would get memory corruption and likely
a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().
Only root can trigger this bug.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
Cc: <stable@vger.kernel.org>
Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
Reported-by: shqking <shqking@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'kernel/trace/trace.c')
0 files changed, 0 insertions, 0 deletions