diff options
| author | NeilBrown <neilb@suse.com> | 2015-07-24 09:22:16 +1000 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-08-26 19:58:43 +0200 |
| commit | c700bbee3d79762737fbc1caa5d936bc5f119144 (patch) | |
| tree | 0ba7cafe93c9613b4765df84bb568f9899c38126 /kernel/sysctl_binary.c | |
| parent | 6b075aca37e98f37e418330606c89af86c786ba2 (diff) | |
md/raid1: fix test for 'was read error from last working device'.
commit 34cab6f42003cb06f48f86a86652984dec338ae9 upstream.
When we get a read error from the last working device, we don't
try to repair it, and don't fail the device. We simple report a
read error to the caller.
However the current test for 'is this the last working device' is
wrong.
When there is only one fully working device, it assumes that a
non-faulty device is that device. However a spare which is rebuilding
would be non-faulty but so not the only working device.
So change the test from "!Faulty" to "In_sync". If ->degraded says
there is only one fully working device and this device is in_sync,
this must be the one.
This bug has existed since we allowed read_balance to read from
a recovering spare in v3.0
Reported-and-tested-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Fixes: 76073054c95b ("md/raid1: clean up read_balance.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Guendhoer <stefan@guendhoer.com>
Diffstat (limited to 'kernel/sysctl_binary.c')
0 files changed, 0 insertions, 0 deletions