diff options
| author | Jason Low <jason.low2@hp.com> | 2013-08-31 01:47:10 -0500 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-09-18 19:40:41 +0200 |
| commit | 512c41113e644d23240b99a07a96ccc7065dd1fb (patch) | |
| tree | fbc6c6b1a5e5ce3b84e4f47a3f636e7088875fed /kernel/sched | |
| parent | ab7b4cf4308dd2895fe7fb6c112c29c81338fd57 (diff) | |
sched: Reduce overestimating rq->avg_idle
Date Thu, 29 Aug 2013 13:05:34 -0700
When updating avg_idle, if the delta exceeds some max value, then avg_idle
gets set to the max, regardless of what the previous avg was. This can cause
avg_idle to often be overestimated.
This patch modifies the way we update avg_idle by always updating it with the
function call to update_avg() first. Then, if avg_idle exceeds the max, we set
it to the max.
Signed-off-by: Jason Low <jason.low2@hp.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Paul Reioux <reioux@gmail.com>
Signed-off-by: engstk <eng.stk@sapo.pt>
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/core.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ed57354ad..22b248d7d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1505,10 +1505,11 @@ ttwu_do_wakeup(struct rq *rq, struct task_struct *p, int wake_flags) u64 delta = rq->clock - rq->idle_stamp; u64 max = 2*sysctl_sched_migration_cost; - if (delta > max) + update_avg(&rq->avg_idle, delta); + + if (rq->avg_idle > max) rq->avg_idle = max; - else - update_avg(&rq->avg_idle, delta); + rq->idle_stamp = 0; } #endif |