diff options
| author | Ilya Dryomov <idryomov@gmail.com> | 2015-06-29 19:30:23 +0300 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-08-26 19:30:28 +0200 |
| commit | 8251284acef829f15ae3f281a232dc79a163ea52 (patch) | |
| tree | b93a1c69b3ce32ed74b3bd9fffde7b1b93e36f88 /include | |
| parent | bfe9b25da894e157e86e7d89904e52d616390571 (diff) | |
crush: fix a bug in tree bucket decode
commit 82cd003a77173c91b9acad8033fb7931dac8d751 upstream.
struct crush_bucket_tree::num_nodes is u8, so ceph_decode_8_safe()
should be used. -Wconversion catches this, but I guess it went
unnoticed in all the noise it spews. The actual problem (at least for
common crushmaps) isn't the u32 -> u8 truncation though - it's the
advancement by 4 bytes instead of 1 in the crushmap buffer.
Fixes: http://tracker.ceph.com/issues/2759
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Guendhoer <stefan@guendhoer.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions