aboutsummaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorChao Yu <yuchao0@huawei.com>2016-11-17 20:53:31 +0800
committerMister Oyster <oysterized@gmail.com>2017-04-13 12:34:29 +0200
commit611d54943c680fa49969228e3350a87aab38e0e8 (patch)
tree4fa85a92d7d789eb7ef1cbe70b31d389f5213b60 /include
parent134e5fc7e9c19db05289c803957ccd9814f7473b (diff)
f2fs: fix fdatasync
For below two cases, we can't guarantee data consistence: a) 1. xfs_io "pwrite 0 4195328" "fsync" 2. xfs_io "pwrite 4195328 1024" "fdatasync" 3. godown 4. umount & mount --> isize we updated before fdatasync won't be recovered b) 1. xfs_io "pwrite -S 0xcc 0 4202496" "fsync" 2. xfs_io "fpunch 4194304 4096" "fdatasync" 3. godown 4. umount & mount --> dnode we punched before fdatasync won't be recovered The reason is that normally fdatasync won't be aware of modification of metadata in file, e.g. isize changing, dnode updating, so in ->fsync we will skip flushing node pages for above cases, result in making fdatasynced file being lost during recovery. Currently we have introduced DIRTY_META global list in sbi for tracking dirty inode selectively, so in fdatasync we can choose to flush nodes depend on dirty state of current inode in the list. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions