diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-10-24 17:22:01 +0200 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-04-11 10:58:55 +0200 |
| commit | 058ac797a6cbf28adbc2bf32f17c8dd25774c212 (patch) | |
| tree | 2ff9f42c959c2b035c51ba11ff742e296fbdef4a /include/linux/kernel.h | |
| parent | 4ed0b1ee53bbf0363ddaaa66e469531db5225d69 (diff) | |
staging: iio: ad5933: avoid uninitialized variable in error case
commit 34eee70a7b82b09dbda4cb453e0e21d460dae226 upstream.
The ad5933_i2c_read function returns an error code to indicate
whether it could read data or not. However ad5933_work() ignores
this return code and just accesses the data unconditionally,
which gets detected by gcc as a possible bug:
drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work':
drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
This adds minimal error handling so we only evaluate the
data if it was correctly read.
Link: https://patchwork.kernel.org/patch/8110281/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'include/linux/kernel.h')
0 files changed, 0 insertions, 0 deletions