aboutsummaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorDaniel Rosenberg <drosen@google.com>2017-03-10 18:58:25 -0800
committerMister Oyster <oysterized@gmail.com>2017-04-13 12:35:21 +0200
commitd7bcf04561373461c48e98ca2fbc1c9380fbd463 (patch)
treea643020dc71bedd58aacb22261dde911c57a75b4 /fs
parentb6d14140b12586759ae2da78f8cd02cb16439faa (diff)
ANDROID: sdcardfs: Remove uninformative prints
At best these prints do not provide useful information, and at worst, some allow userspace to abuse the kernel log. Signed-off-by: Daniel Rosenberg <drosen@google.com> Bug: 36138424 Change-Id: I812c57cc6a22b37262935ab77f48f3af4c36827e
Diffstat (limited to 'fs')
-rwxr-xr-xfs/sdcardfs/derived_perm.c1
-rwxr-xr-xfs/sdcardfs/file.c3
-rwxr-xr-xfs/sdcardfs/inode.c24
-rwxr-xr-xfs/sdcardfs/lookup.c3
4 files changed, 1 insertions, 30 deletions
diff --git a/fs/sdcardfs/derived_perm.c b/fs/sdcardfs/derived_perm.c
index 0f0b2543f..a2d0023ec 100755
--- a/fs/sdcardfs/derived_perm.c
+++ b/fs/sdcardfs/derived_perm.c
@@ -428,7 +428,6 @@ int setup_obb_dentry(struct dentry *dentry, struct path *lower_path)
if(!err) {
/* the obbpath base has been found */
- printk(KERN_INFO "sdcardfs: the sbi->obbpath is found\n");
pathcpy(lower_path, &obbpath);
} else {
/* if the sbi->obbpath is not available, we can optionally
diff --git a/fs/sdcardfs/file.c b/fs/sdcardfs/file.c
index 71601dd8e..03b9070c4 100755
--- a/fs/sdcardfs/file.c
+++ b/fs/sdcardfs/file.c
@@ -217,9 +217,6 @@ static int sdcardfs_open(struct inode *inode, struct file *file)
}
if(!check_caller_access_to_name(parent->d_inode, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
err = -EACCES;
goto out_err;
}
diff --git a/fs/sdcardfs/inode.c b/fs/sdcardfs/inode.c
index 79b5c67c8..42ffc0a6d 100755
--- a/fs/sdcardfs/inode.c
+++ b/fs/sdcardfs/inode.c
@@ -68,9 +68,6 @@ static int sdcardfs_create(struct inode *dir, struct dentry *dentry,
struct fs_struct *copied_fs;
if(!check_caller_access_to_name(dir, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
err = -EACCES;
goto out_eacces;
}
@@ -170,9 +167,6 @@ static int sdcardfs_unlink(struct inode *dir, struct dentry *dentry)
const struct cred *saved_cred = NULL;
if(!check_caller_access_to_name(dir, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
err = -EACCES;
goto out_eacces;
}
@@ -280,9 +274,6 @@ static int sdcardfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode
struct qstr q_data = QSTR_LITERAL("data");
if(!check_caller_access_to_name(dir, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
err = -EACCES;
goto out_eacces;
}
@@ -392,9 +383,6 @@ static int sdcardfs_rmdir(struct inode *dir, struct dentry *dentry)
const struct cred *saved_cred = NULL;
if(!check_caller_access_to_name(dir, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
err = -EACCES;
goto out_eacces;
}
@@ -481,9 +469,6 @@ static int sdcardfs_rename(struct inode *old_dir, struct dentry *old_dentry,
if(!check_caller_access_to_name(old_dir, &old_dentry->d_name) ||
!check_caller_access_to_name(new_dir, &new_dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " new_dentry: %s, task:%s\n",
- __func__, new_dentry->d_name.name, current->comm);
err = -EACCES;
goto out_eacces;
}
@@ -758,12 +743,8 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
if (!err) {
/* check the Android group ID */
parent = dget_parent(dentry);
- if(!check_caller_access_to_name(parent->d_inode, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
+ if(!check_caller_access_to_name(parent->d_inode, &dentry->d_name))
err = -EACCES;
- }
dput(parent);
}
@@ -875,9 +856,6 @@ static int sdcardfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
parent = dget_parent(dentry);
if(!check_caller_access_to_name(parent->d_inode, &dentry->d_name)) {
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
dput(parent);
return -EACCES;
}
diff --git a/fs/sdcardfs/lookup.c b/fs/sdcardfs/lookup.c
index 18ce7e4e3..5933304cb 100755
--- a/fs/sdcardfs/lookup.c
+++ b/fs/sdcardfs/lookup.c
@@ -400,9 +400,6 @@ struct dentry *sdcardfs_lookup(struct inode *dir, struct dentry *dentry,
if(!check_caller_access_to_name(parent->d_inode, &dentry->d_name)) {
ret = ERR_PTR(-EACCES);
- printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
- " dentry: %s, task:%s\n",
- __func__, dentry->d_name.name, current->comm);
goto out_err;
}