diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2018-05-17 17:18:30 -0400 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2018-12-02 00:02:05 +0100 |
| commit | bae3b8647efb3b63ac24f5fffad1ff8f906f7b01 (patch) | |
| tree | 0c56428ddeffb583a010dc806ec6b27324ed69e8 /fs/ext2 | |
| parent | 10e5cd57649462571e77077ea7c7bbe8261a3bcb (diff) | |
ext2: fix a block leak
commit 5aa1437d2d9a068c0334bd7c9dafa8ec4f97f13b upstream.
open file, unlink it, then use ioctl(2) to make it immutable or
append only. Now close it and watch the blocks *not* freed...
Immutable/append-only checks belong in ->setattr().
Note: the bug is old and backport to anything prior to 737f2e93b972
("ext2: convert to use the new truncate convention") will need
these checks lifted into ext2_setattr().
Cc: stable@kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext2')
| -rw-r--r-- | fs/ext2/inode.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 99d84ce03..13e0484cb 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1169,21 +1169,11 @@ do_indirects: static void ext2_truncate_blocks(struct inode *inode, loff_t offset) { - /* - * XXX: it seems like a bug here that we don't allow - * IS_APPEND inode to have blocks-past-i_size trimmed off. - * review and fix this. - * - * Also would be nice to be able to handle IO errors and such, - * but that's probably too much to ask. - */ if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode))) return; if (ext2_inode_is_fast_symlink(inode)) return; - if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) - return; __ext2_truncate_blocks(inode, offset); } |