diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-04-13 06:32:15 -0300 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-06-25 16:48:09 +0200 |
| commit | fbc84ec60313d4fd00d065193e55b10b597702e8 (patch) | |
| tree | 450ec6690c0a6575812d1f4ee73f39aafc27eb7e /drivers | |
| parent | 16c9df31c659e32d2a0f11cfa3347547a033f757 (diff) | |
media: info leak in __media_device_enum_links()
These structs have holes and reserved struct members which aren't
cleared. I've added a memset() so we don't leak stack information.
Change-Id: I08bebb915f399fe13a0b80bd0c881b182a719de7
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/media/media-device.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index fdb5840f0..88c1606fd 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -141,6 +141,8 @@ static long __media_device_enum_links(struct media_device *mdev, for (p = 0; p < entity->num_pads; p++) { struct media_pad_desc pad; + + memset(&pad, 0, sizeof(pad)); media_device_kpad_to_upad(&entity->pads[p], &pad); if (copy_to_user(&links->pads[p], &pad, sizeof(pad))) return -EFAULT; @@ -158,6 +160,7 @@ static long __media_device_enum_links(struct media_device *mdev, if (entity->links[l].source->entity != entity) continue; + memset(&link, 0, sizeof(link)); media_device_kpad_to_upad(entity->links[l].source, &link.source); media_device_kpad_to_upad(entity->links[l].sink, |