diff options
| author | Johan Hovold <johan@kernel.org> | 2017-03-16 11:36:13 -0700 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2017-06-17 15:54:09 +0200 |
| commit | 8db0afe29cade01ea86fcefbde4809ec55d96e14 (patch) | |
| tree | 749e76c7018eb523ea0f57ca3a4b65ab3a30c0c4 /drivers | |
| parent | ae81d47f9ffeeaa8a95ad453eb0106deef67c79c (diff) | |
Input: ims-pcu - validate number of endpoints before using them
commit 1916d319271664241b7aa0cd2b05e32bdb310ce9 upstream.
Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack control-interface endpoints.
Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/input/misc/ims-pcu.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 3e6491db5..ce0e1e670 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -1437,6 +1437,10 @@ static int ims_pcu_parse_cdc_data(struct usb_interface *intf, struct ims_pcu *pc return -EINVAL; alt = pcu->ctrl_intf->cur_altsetting; + + if (alt->desc.bNumEndpoints < 1) + return -ENODEV; + pcu->ep_ctrl = &alt->endpoint[0].desc; pcu->max_ctrl_size = usb_endpoint_maxp(pcu->ep_ctrl); |