diff options
| author | Pan Bian <bianpan2016@163.com> | 2016-12-01 14:25:44 +0800 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2017-06-17 15:49:03 +0200 |
| commit | 4bb40b8355a86cb158db33f746fda161b88715f2 (patch) | |
| tree | 6f127dbadd90921fc6121c105156af51c0aa2a07 /drivers | |
| parent | 0334b098102026d4f60e6a0ffaecadb7bd706be3 (diff) | |
clk: clk-wm831x: fix a logic error
commit 20979202ee6e4c68dab7bcf408787225a656d18e upstream.
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Fixes: f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/clk/clk-wm831x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c index 917a3ab48..e2e5e76e9 100644 --- a/drivers/clk/clk-wm831x.c +++ b/drivers/clk/clk-wm831x.c @@ -248,7 +248,7 @@ static int wm831x_clkout_is_enabled(struct clk_hw *hw) if (ret < 0) { dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n", ret); - return true; + return false; } return (ret & WM831X_CLKOUT_ENA) != 0; |