diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-12-13 15:27:04 +0300 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2017-06-17 15:49:10 +0200 |
| commit | 162d8c8ed86ec2675d1af5c310ad1d945ee21a13 (patch) | |
| tree | 68eea423f66afdf8b147bc7e078191b47f675169 /drivers | |
| parent | d73062b98c447e5651b98e6d4b46ad40fd4e7f05 (diff) | |
| download | android_kernel_m2note-162d8c8ed86ec2675d1af5c310ad1d945ee21a13.tar.gz | |
target/iscsi: Fix double free in lio_target_tiqn_addtpg()
commit a91918cd3ea11f91c68e08e1e8ce1b560447a80e upstream.
This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg(). Both functions free the "tpg" pointer on
error so it's a double free bug. The memory is allocated in the caller
so it should be freed in the caller and not here.
Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/target/iscsi/iscsi_target_tpg.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c index 75a4e8384..a6801e8a8 100644 --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c @@ -256,7 +256,6 @@ err_out: iscsi_release_param_list(tpg->param_list); tpg->param_list = NULL; } - kfree(tpg); return -ENOMEM; } |