diff options
| author | Ian Abbott <abbotti@mev.co.uk> | 2015-08-11 13:05:10 +0100 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-08-26 20:44:34 +0200 |
| commit | 7edd9cb51007f2e6624a33c9978bc0785c214206 (patch) | |
| tree | bfc250f056052bf606b4846c91a8853b63bfe983 /drivers/md/persistent-data | |
| parent | f856e08a348f96ada164bc5ad1b5ec31a67fd9b8 (diff) | |
staging: comedi: adl_pci7x3x: fix digital output on PCI-7230
commit ad83dbd974feb2e2a8cc071a1d28782bd4d2c70e upstream.
The "adl_pci7x3x" driver replaced the "adl_pci7230" and "adl_pci7432"
drivers in commits 8f567c373c4b ("staging: comedi: new adl_pci7x3x
driver") and 657f77d173d3 ("staging: comedi: remove adl_pci7230 and
adl_pci7432 drivers"). Although the new driver code agrees with the
user manuals for the respective boards, digital outputs stopped working
on the PCI-7230. This has 16 digital output channels and the previous
adl_pci7230 driver shifted the 16 bit output state left by 16 bits
before writing to the hardware register. The new adl_pci7x3x driver
doesn't do that. Fix it in `adl_pci7x3x_do_insn_bits()` by checking
for the special case of the subdevice having only 16 channels and
duplicating the 16 bit output state into both halves of the 32-bit
register. That should work both for what the board actually does and
for what the user manual says it should do.
Fixes: 8f567c373c4b ("staging: comedi: new adl_pci7x3x driver")
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Guendhoer <stefan@guendhoer.com>
Diffstat (limited to 'drivers/md/persistent-data')
0 files changed, 0 insertions, 0 deletions