diff options
| author | Amit Pundir <amit.pundir@linaro.org> | 2017-04-11 14:40:31 +0530 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2018-01-20 03:16:03 +0100 |
| commit | 4bbe2cd12cee2a14deb2635d1240f5208a06d0c9 (patch) | |
| tree | 3d37336b20d234259106d8e86160799bab676e06 /drivers/input | |
| parent | d9802a12b40ad2aa169b5cf0df84dda17371637e (diff) | |
ANDROID: Skip building uid_sys_stats and keyreset drivers as modules
Few Android drivers viz. uid_sys_stats and keyreset/combo fail to
build as kernel modules.
uid_sys_stats.ko failed for undefined "tasklist_lock", which got
un-exported in commit c59923a15 ("remove the tasklist_lock export").
Quoting from the commit, "Modules have no business looking at it,
and all instances in drivers have been due to use of too-lowlevel
APIs. Having this symbol exported prevents moving to more scalable
locking schemes for the task list.". So instead of exporting
tasklist_lock again, lets not build uid_sys_stats driver as module.
Similarly skip building keyreset driver as module which call
sys_sync() syscall.
To keep things in perspective we don't build these drivers as modules
in later kernels (android-4.4/4.9) as well.
Change-Id: I6371df72d79c7ad0f0c08e6ebf7e16f1b0970761
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/Kconfig | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig index 518efa2a9..eaa208f37 100644 --- a/drivers/input/Kconfig +++ b/drivers/input/Kconfig @@ -175,15 +175,12 @@ config INPUT_APMPOWER module will be called apm-power. config INPUT_KEYRESET - tristate "Reset key" + bool "Reset key" depends on INPUT select INPUT_KEYCOMBO ---help--- Say Y here if you want to reboot when some keys are pressed; - To compile this driver as a module, choose M here: the - module will be called keyreset. - config INPUT_KEYCOMBO tristate "Key combo" depends on INPUT |