diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2016-10-27 17:29:47 +0300 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-04-11 10:59:03 +0200 |
| commit | 348218bb940029d231a28728b0a273069e1e99d2 (patch) | |
| tree | 1009753a2b2b6cda778bc3a7785b5e4b503e579b /crypto | |
| parent | 305e3de0c96e59288fd4af2b018d6cdc7a082e9f (diff) | |
crypto: algif_skcipher - Fix race condition in skcipher_check_key
commit 1822793a523e5d5730b19cc21160ff1717421bc8 upstream.
We need to lock the child socket in skcipher_check_key as otherwise
two simultaneous calls can cause the parent socket to be freed.
Cc: stable@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/algif_skcipher.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index a7800b7b0..13fd26e23 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -551,22 +551,23 @@ static struct proto_ops algif_skcipher_ops = { static int skcipher_check_key(struct socket *sock) { - int err; + int err = 0; struct sock *psk; struct alg_sock *pask; struct skcipher_tfm *tfm; struct sock *sk = sock->sk; struct alg_sock *ask = alg_sk(sk); + lock_sock(sk); if (ask->refcnt) - return 0; + goto unlock_child; psk = ask->parent; pask = alg_sk(ask->parent); tfm = pask->private; err = -ENOKEY; - lock_sock(psk); + lock_sock_nested(psk, SINGLE_DEPTH_NESTING); if (!tfm->has_key) goto unlock; @@ -580,6 +581,8 @@ static int skcipher_check_key(struct socket *sock) unlock: release_sock(psk); +unlock_child: + release_sock(sk); return err; } |