aboutsummaryrefslogtreecommitdiff
path: root/Documentation/development-process/4.Coding
diff options
context:
space:
mode:
authorDaeho Jeong <daeho.jeong@samsung.com>2016-09-05 22:56:10 -0400
committerMister Oyster <oysterized@gmail.com>2017-04-11 10:58:16 +0200
commita4deb30266e1030042d8f0d1e80c17c666399b79 (patch)
treeaf10771794e967c21b8d8c3b1643016bde9ebadd /Documentation/development-process/4.Coding
parent60e21a68385fa1bdaa7de42aac6e697a519592a3 (diff)
ext4: reinforce check of i_dtime when clearing high fields of uid and gid
commit 93e3b4e6631d2a74a8cf7429138096862ff9f452 upstream. Now, ext4_do_update_inode() clears high 16-bit fields of uid/gid of deleted and evicted inode to fix up interoperability with old kernels. However, it checks only i_dtime of an inode to determine whether the inode was deleted and evicted, and this is very risky, because i_dtime can be used for the pointer maintaining orphan inode list, too. We need to further check whether the i_dtime is being used for the orphan inode list even if the i_dtime is not NULL. We found that high 16-bit fields of uid/gid of inode are unintentionally and permanently cleared when the inode truncation is just triggered, but not finished, and the inode metadata, whose high uid/gid bits are cleared, is written on disk, and the sudden power-off follows that in order. Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com> Signed-off-by: Hobin Woo <hobin.woo@samsung.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'Documentation/development-process/4.Coding')
0 files changed, 0 insertions, 0 deletions