aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Rosenberg <drosen@google.com>2017-07-19 17:16:43 -0700
committerMoyster <oysterized@gmail.com>2017-07-21 12:18:56 +0200
commitdcb1bbdc06e817785382c17277b011194d266674 (patch)
tree166233fdeaf77bbc195415cc067087467d4736be
parent04f2202b1f46695f7e8412e823489c7ab10a40f7 (diff)
downloadandroid_kernel_m2note-dcb1bbdc06e817785382c17277b011194d266674.tar.gz
ANDROID: sdcardfs: Remove unnecessary lock
The mmap_sem lock does not appear to be protecting anything, and has been removed in Samsung's more recent versions of sdcardfs. Signed-off-by: Daniel Rosenberg <drosen@google.com> Change-Id: I76ff3e33002716b8384fc8be368028ed63dffe4e Bug: 63785372
-rwxr-xr-xfs/sdcardfs/inode.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/sdcardfs/inode.c b/fs/sdcardfs/inode.c
index 6a452757a..d22aee3b3 100755
--- a/fs/sdcardfs/inode.c
+++ b/fs/sdcardfs/inode.c
@@ -779,13 +779,9 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
* afterwards in the other cases: we fsstack_copy_inode_size from
* the lower level.
*/
- if (current->mm)
- down_write(&current->mm->mmap_sem);
if (ia->ia_valid & ATTR_SIZE) {
err = inode_newsize_ok(&tmp, ia->ia_size);
if (err) {
- if (current->mm)
- up_write(&current->mm->mmap_sem);
goto out;
}
truncate_setsize(inode, ia->ia_size);
@@ -808,8 +804,6 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
err = notify_change2(lower_mnt, lower_dentry, &lower_ia); /* note: lower_ia */
mutex_unlock(&lower_dentry->d_inode->i_mutex);
- if (current->mm)
- up_write(&current->mm->mmap_sem);
if (err)
goto out;