diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2014-04-13 20:59:38 +0200 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2019-05-02 17:36:05 +0200 |
| commit | a44eca0e99e666af7f49a511df785269fcb8821a (patch) | |
| tree | ca9fdbdc13e297d9071d11d79039ed4052442711 | |
| parent | 4d7a674be92949ba70cd6136561c02172b9a0307 (diff) | |
tracing: syscall_regfunc() should not skip kernel threads
syscall_regfunc() ignores the kernel threads because "it has no effect",
see cc3b13c1 "Don't trace kernel thread syscalls" which added this check.
However, this means that a user-space task spawned by call_usermodehelper()
will run without TIF_SYSCALL_TRACEPOINT if sys_tracepoint_refcount != 0.
Remove this check. The unnecessary report from ret_from_fork path mentioned
by cc3b13c1 is no longer possible, see See commit fb45550d76bb5 "make sure
that kernel_thread() callbacks call do_exit() themselves".
A kernel_thread() callback can only return and take the int_ret_from_sys_call
path after do_execve() succeeds, otherwise the kernel will crash. But in this
case it is no longer a kernel thread and thus is needs TIF_SYSCALL_TRACEPOINT.
Link: http://lkml.kernel.org/p/20140413185938.GD20668@redhat.com
Change-Id: Ic61b8b2d4f2cec27d7cf681a8b39020ed65e2e43
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| -rw-r--r-- | kernel/tracepoint.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 78762de1f..918563cc8 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -753,9 +753,7 @@ void syscall_regfunc(void) if (!sys_tracepoint_refcount) { read_lock(&tasklist_lock); for_each_process_thread(p, t) { - /* Skip kernel threads. */ - if (!(t->flags & PF_KTHREAD)) - set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT); + set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT); } read_unlock(&tasklist_lock); } |