diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2016-04-11 15:15:38 -0700 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-04-13 12:33:15 +0200 |
| commit | a17f98f9adfac56a436505505de9819eff7e3425 (patch) | |
| tree | 49628b7567953baaab1254d26a4d645a14166f17 | |
| parent | dd502e4ea6da3601bc29639142c10937c3bcd26f (diff) | |
| download | android_kernel_m2note-a17f98f9adfac56a436505505de9819eff7e3425.tar.gz | |
f2fs: use dget_parent and file_dentry in f2fs_file_open
This patch synced with the below two ext4 crypto fixes together.
In 4.6-rc1, f2fs newly introduced accessing f_path.dentry which crashes
overlayfs. To fix, now we need to use file_dentry() to access that field.
[Backport NOTE]
- Over 4.2, it should use file_dentry
Fixes: c0a37d487884 ("ext4: use file_dentry()")
Fixes: 9dd78d8c9a7b ("ext4: use dget_parent() in ext4_file_open()")
Cc: Miklos Szeredi <mszeredi@redhat.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
| -rw-r--r-- | fs/f2fs/file.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 79eda1689..353b2fa27 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -460,7 +460,7 @@ static int f2fs_file_mmap(struct file *file, struct vm_area_struct *vma) static int f2fs_file_open(struct inode *inode, struct file *filp) { int ret = generic_file_open(inode, filp); - struct inode *dir = filp->f_path.dentry->d_parent->d_inode; + struct dentry *dir; if (!ret && f2fs_encrypted_inode(inode)) { ret = fscrypt_get_encryption_info(inode); @@ -469,9 +469,13 @@ static int f2fs_file_open(struct inode *inode, struct file *filp) if (!fscrypt_has_encryption_key(inode)) return -ENOKEY; } - if (f2fs_encrypted_inode(dir) && - !fscrypt_has_permitted_context(dir, inode)) + dir = dget_parent(filp->f_path.dentry); + if (f2fs_encrypted_inode(dir->d_inode) && + !fscrypt_has_permitted_context(dir->d_inode, inode)) { + dput(dir); return -EPERM; + } + dput(dir); return ret; } |