diff options
| author | Andrea Arcangeli <andrea@cpushare.com> | 2017-10-10 23:47:52 +0200 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-10-21 00:44:50 +0200 |
| commit | 7f4eab0e0a02c586b53466dc016f1bbd7b17b69e (patch) | |
| tree | 79bad5dfb3859eda1ae2161fced0b8f53382e17f | |
| parent | 13b1124d7e445e76b5cc158f6b11faea07a3bba9 (diff) | |
sdcardfs: fix space leak
Don't keep looked up dentries around because there's no notification
when the lowerfs unlinks an inode, to collect the upper dentry cache so
the lower inode reference can be released and the storage space
released.
This effectively disables the dcache lookups but it should still be much
faster than fuse sdcardfs.
The alternative is to add a notification mechanism to keep two separate
dcache layers in sync which isn't trivial, or stop ever touching the
lower fs and remove that path.replace from VolumeInfo.java.
Change-Id: I211bd676834126f6f65b3d09ebe951d0375d7985
Signed-off-by: Kevin F. Haggerty <haggertk@lineageos.org>
| -rw-r--r--[-rwxr-xr-x] | fs/sdcardfs/dentry.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/sdcardfs/dentry.c b/fs/sdcardfs/dentry.c index c8f3bcbfb..80e753d23 100755..100644 --- a/fs/sdcardfs/dentry.c +++ b/fs/sdcardfs/dentry.c @@ -185,7 +185,13 @@ static void sdcardfs_canonical_path(const struct path *path, sdcardfs_get_real_lower(path->dentry, actual_path); } +static int sdcardfs_d_delete(const struct dentry * dentry) +{ + return dentry->d_inode && !S_ISDIR(dentry->d_inode->i_mode); +} + const struct dentry_operations sdcardfs_ci_dops = { + .d_delete = sdcardfs_d_delete, .d_revalidate = sdcardfs_d_revalidate, .d_release = sdcardfs_d_release, .d_hash = sdcardfs_hash_ci, |