aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVinicius Costa Gomes <vinicius.gomes@intel.com>2018-03-14 13:32:09 -0700
committerMoyster <oysterized@gmail.com>2019-05-02 17:09:18 +0200
commit76b0297579e9f50056899251af28030a1641c356 (patch)
tree992bcec021f1bea8ac1e6dfbae5ce58f40579074
parent79c6e9f5b8e1fdc2bab71dcdd6d49107092c3691 (diff)
skbuff: Fix not waking applications when errors are enqueued
commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 upstream. When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Change-Id: Ibb67d26fefc757ff49c7e38d92ae23b6b48b9008 Reported-by: Randy E. Witt <randy.e.witt@intel.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Moyster <oysterized@gmail.com>
-rw-r--r--net/core/skbuff.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 8a5c11636..03c950bf8 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3288,7 +3288,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb)
skb_queue_tail(&sk->sk_error_queue, skb);
if (!sock_flag(sk, SOCK_DEAD))
- sk->sk_data_ready(sk, len);
+ sk->sk_error_report(sk);
return 0;
}
EXPORT_SYMBOL(sock_queue_err_skb);