diff options
| author | Willy Tarreau <w@1wt.eu> | 2017-05-16 19:18:55 +0200 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2017-06-17 16:12:42 +0200 |
| commit | 5b428ae7bb6de789bb49e3beda22ad271744b6d0 (patch) | |
| tree | 5868cf80e7cab4e9508a2940f18a033d859496c0 | |
| parent | 0c95d3e1a799979a63b5cc469382d90a664c6aaa (diff) | |
char: lp: fix possible integer overflow in lp_setup()
commit 3e21f4af170bebf47c187c1ff8bf155583c9f3b1 upstream.
The lp_setup() code doesn't apply any bounds checking when passing
"lp=none", and only in this case, resulting in an overflow of the
parport_nr[] array. All versions in Git history are affected.
Reported-By: Roee Hay <roee.hay@hcl.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/char/lp.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/char/lp.c b/drivers/char/lp.c index 0913d7942..6b619105d 100644 --- a/drivers/char/lp.c +++ b/drivers/char/lp.c @@ -857,7 +857,11 @@ static int __init lp_setup (char *str) } else if (!strcmp(str, "auto")) { parport_nr[0] = LP_PARPORT_AUTO; } else if (!strcmp(str, "none")) { - parport_nr[parport_ptr++] = LP_PARPORT_NONE; + if (parport_ptr < LP_NO) + parport_nr[parport_ptr++] = LP_PARPORT_NONE; + else + printk(KERN_INFO "lp: too many ports, %s ignored.\n", + str); } else if (!strcmp(str, "reset")) { reset = 1; } |