diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2018-07-01 13:56:54 -0700 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2018-12-01 22:58:32 +0100 |
| commit | 4c2f13a2b0cb8b1c460249519c95eb0c58cac246 (patch) | |
| tree | c2f7c6a187741074a83f0d32190c857abea23c65 | |
| parent | 0f91fd8a89770b0a61f2cd2bfff4df506ac4022d (diff) | |
| download | android_kernel_m2note-4c2f13a2b0cb8b1c460249519c95eb0c58cac246.tar.gz | |
configfs: replace strncpy with memcpy
commit 1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd upstream.
gcc 8.1.0 complains:
fs/configfs/symlink.c:67:3: warning:
'strncpy' output truncated before terminating nul copying as many
bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu@cybertrust.co.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/configfs/symlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c index cc9f2546e..f539b596a 100644 --- a/fs/configfs/symlink.c +++ b/fs/configfs/symlink.c @@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length) /* back up enough to print this bus id with '/' */ length -= cur; - strncpy(buffer + length,config_item_name(p),cur); + memcpy(buffer + length, config_item_name(p), cur); *(buffer + --length) = '/'; } } |