diff options
| author | Richard Guy Briggs <rgb@redhat.com> | 2014-11-12 14:01:34 -0500 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2019-07-06 11:57:03 +0200 |
| commit | 33e7716f0675760244385e317daf5665c48b926a (patch) | |
| tree | abb3e73c74f40345e626b1bf259435833e694596 | |
| parent | 84e818d35b6347786ecd1b9b432a993a25fe7228 (diff) | |
selinux: convert WARN_ONCE() to printk() in selinux_nlmsg_perm()
Convert WARN_ONCE() to printk() in selinux_nlmsg_perm().
After conversion from audit_log() in commit e173fb26, WARN_ONCE() was
deemed too alarmist, so switch it to printk().
Change-Id: Ibe5bc4715db1de8aca55a3014955b942798d165a
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
[PM: Changed to printk(WARNING) so we catch all of the different
invalid netlink messages. In Richard's defense, he brought this
point up earlier, but I didn't understand his point at the time.]
Signed-off-by: Paul Moore <pmoore@redhat.com>
| -rw-r--r-- | security/selinux/hooks.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index b704131af..de4520021 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4736,9 +4736,10 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm); if (err) { if (err == -EINVAL) { - WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:" - " protocol=%hu nlmsg_type=%hu sclass=%hu\n", - sk->sk_protocol, nlh->nlmsg_type, sksec->sclass); + printk(KERN_WARNING + "SELinux: unrecognized netlink message:" + " protocol=%hu nlmsg_type=%hu sclass=%hu\n", + sk->sk_protocol, nlh->nlmsg_type, sksec->sclass); if (!selinux_enforcing || security_get_allow_unknown()) err = 0; } |