diff options
| author | Eric Dumazet <edumazet@google.com> | 2015-01-28 06:06:36 -0800 |
|---|---|---|
| committer | Moyster <oysterized@gmail.com> | 2016-09-18 12:47:05 +0200 |
| commit | 2afc063b1f9803b0f86f884176aef7365563a845 (patch) | |
| tree | ac8c36446947baed77a7d11926cf231b84826df3 | |
| parent | 93c0237e2bbe6e8c48c9411be54adcdf33dd1489 (diff) | |
pkt_sched: fq: remove useless TIME_WAIT check
TIME_WAIT sockets are not owning any skb.
ip_send_unicast_reply() and tcp_v6_send_response() both use
regular sockets.
We can safely remove a test in sch_fq and save one cache line miss,
as sk_state is far away from sk_pacing_rate.
Tested at Google for about one year.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/sch_fq.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c index 5e592a51d..1828c0d4e 100644 --- a/net/sched/sch_fq.c +++ b/net/sched/sch_fq.c @@ -1,7 +1,7 @@ /* * net/sched/sch_fq.c Fair Queue Packet Scheduler (per flow pacing) * - * Copyright (C) 2013 Eric Dumazet <edumazet@google.com> + * Copyright (C) 2013-2015 Eric Dumazet <edumazet@google.com> * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -472,7 +472,7 @@ begin: goto out; rate = q->flow_max_rate; - if (skb->sk && skb->sk->sk_state != TCP_TIME_WAIT) + if (skb->sk) rate = min(skb->sk->sk_pacing_rate, rate); if (rate != ~0U) { |