diff options
| author | Anmin Hsu <anmin.hsu@mediatek.com> | 2015-10-01 12:04:10 +0800 |
|---|---|---|
| committer | Mister Oyster <oysterized@gmail.com> | 2017-04-25 11:28:23 +0200 |
| commit | 2485849408a09c241f49ce9bf370762310a7420b (patch) | |
| tree | 0270154382429e02425421f03fc93e3f4ac1b5dd | |
| parent | 58067019ce093efa129f7b1e07919da247fa63e7 (diff) | |
| download | android_kernel_m2note-2485849408a09c241f49ce9bf370762310a7420b.tar.gz | |
mlog: Fixed stack overflow
[Detail]
Function sprintf does not check the length of buffer.
[Solution]
Using snprintf prevent stack overflow.
[Feature] Monkey Test
MTK-Commit-Id: 699464af6ac730e4edd21773b02aa5e1f6dc9403
Change-Id: I238b71ac9966b1967f4c93ffeb29a7c88d441193
Signed-off-by: mtk10008 <tehsin.lin@mediatek.com>
CR-Id: ALPS02316340
| -rw-r--r-- | drivers/misc/mediatek/mlog/mlog_logger.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/mediatek/mlog/mlog_logger.c b/drivers/misc/mediatek/mlog/mlog_logger.c index af0a87e31..a7ef1045e 100644 --- a/drivers/misc/mediatek/mlog/mlog_logger.c +++ b/drivers/misc/mediatek/mlog/mlog_logger.c @@ -725,7 +725,7 @@ int mlog_doread(char __user *buf, size_t len) v = '\n'; } /* MLOG_PRINTK("[mlog] %d: %s\n", strfmt_idx, strfmt_list[strfmt_idx]); */ - size = sprintf(mlog_str, strfmt_list[strfmt_idx++], v); + size = snprintf(mlog_str, MLOG_STR_LEN, strfmt_list[strfmt_idx++], v); if (strfmt_idx >= strfmt_len) strfmt_idx = strfmt_proc; |