xavi
/
pcsxr
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Consider sockets less than zero as invalid

This commit is contained in:
Xavier Del Campo Romero 2020-12-30 23:54:49 +01:00
parent 364102c0b6
commit 28b866b150
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdbstub/gdbstub_sys.c
View File

@ -367,9 +367,7 @@ static void stop_thread(void)
#ifdef _POSIX_VERSION #ifdef _POSIX_VERSION
void gdbstub_sys_recv(struct msg *msg) void gdbstub_sys_recv(struct msg *msg)
{ {
while (out_queue < 0) if (out_queue >= 0)
;
{ {
const ssize_t sz = mq_receive(out_queue, (char *)msg, sizeof *msg, 0); const ssize_t sz = mq_receive(out_queue, (char *)msg, sizeof *msg, 0);
@ -406,7 +404,7 @@ void dbg_stop(void)
void dbg_start(void) void dbg_start(void)
{ {
if (server_socket > 0) { if (server_socket >= 0) {
fprintf(stderr, "gdb server already started\n"); fprintf(stderr, "gdb server already started\n");
return; return;
} }
@ -415,7 +413,7 @@ void dbg_start(void)
server_socket = StartServer(port); server_socket = StartServer(port);
if (server_socket > 0) { if (server_socket >= 0) {
printf("GDB server started on port %hu.\n", port); printf("GDB server started on port %hu.\n", port);
if (queue_create()) if (queue_create())
fprintf(stderr, "could not create gdb stub internal queues\n"); fprintf(stderr, "could not create gdb stub internal queues\n");

2
libpcsxcore/socket.c
View File

@ -180,7 +180,7 @@ static enum read_socket_err ReadSocketOS(int client_socket, char *buf, size_t *c
enum read_socket_err ReadSocket(int client_socket, char *buf, size_t *const len) { enum read_socket_err ReadSocket(int client_socket, char *buf, size_t *const len) {
char * endl; char * endl;
if (!client_socket || !buf || !len || !*len) if (client_socket < 0 || !buf || !len || !*len)
return READ_SOCKET_ERR_INVALID_ARG; return READ_SOCKET_ERR_INVALID_ARG;
return ReadSocketOS(client_socket, buf, len); return ReadSocketOS(client_socket, buf, len);