aboutsummaryrefslogtreecommitdiff
path: root/main.c
Commit message (Collapse)AuthorAgeFilesLines
* Implement file/directory removalremoveXavier Del Campo Romero2023-07-081-0/+332
| | | | | | | | | | | | | | | The following workflow has been implemented: - A new checkbox for each object inside a directory is shown. - When one or more objects are selected, the user submits a request through a HTML5 form. - Then, slcl will ask the user for confirmation, listing the selected objects, while reminding the user about the effects. - The user confirms the selection. - slcl removes the selected objects. All objects from non-empty directories are removed, too. - Finally, slcl redirects the user to the directory the request was made from.
* cftw: Allow directories to call the user callbackXavier Del Campo Romero2023-07-081-0/+3
| | | | | | | | This provides a few benefits: - This will allow searching for directories by name. - Future commits will allow to remove files and directories, so this change was also required for cftw.
* main.c: Fix use-after-free on failed search_fnXavier Del Campo Romero2023-07-071-1/+1
| | | | | | | | When search_fn fails, it must free `r` before `results`, as the former is assigned based on the latter - otherwise, it would lead to undefined behaviour. So far, only memory allocation errors would make search_fn to fail.
* main.c: Use ISO C99-compatible declaration for mainXavier Del Campo Romero2023-07-061-1/+1
| | | | | | | | | | | C99 ยง5.1.2.2.1 only defines the following declarations for main: - int main(void) - int main(int argc, char *argv[]) While the use of equivalent types (e.g.: char **argv) is allowed, const char ** would not be considered equivalent, and thus an invalid declaration depending on the implementation.
* Implement searchXavier Del Campo Romero2023-06-061-6/+224
| | | | | | This new feature adds a HTML form on each directory listing that allows to search files recursively, starting from the current user directory. Wildcard patterns are also allowed.
* Split wildcard_cmp into its own componentXavier Del Campo Romero2023-06-061-0/+1
| | | | Future commits will make use of this function outside handler.c.
* http.c: Decode URL resource and parameters separatelyXavier Del Campo Romero2023-05-011-10/+3
| | | | | | | | | Given the following contrived example request: /example%FB%DC&arg%DE1=examplevalue%AA slcl must decode each token separately, so that percent-encoded characters '&', '=' or '?' do not get accidently intepreted.
* Fix missing error checks for strtoul(3)Xavier Del Campo Romero2023-05-011-3/+4
|
* Implement file previewsXavier Del Campo Romero2023-04-231-7/+13
| | | | | | | | | | | | | When using HTTP "Content-Disposition: attachment;", users are forced to download files in order to use them, whereas others might prefer to open them in the browser. Therefore, now that URL parameters are supported by http.h, previews can be forced by adding "preview=1" or "preview=true" (case-insensitive) as a URL parameters. Any other parameters are ignored by slcl. For users, a "Preview" link has been added next to the "Share" button for each file.
* main.c: Use S_ISDIR in ensure_dirXavier Del Campo Romero2023-03-251-0/+5
|
* Define _POSIX_C_SOURCEXavier Del Campo Romero2023-03-241-0/+2
| | | | | This allows using the default compiler defined by make(1) (i.e., c99(1)), thus improving POSIX compatibility.
* Send response on quota exceededXavier Del Campo Romero2023-03-201-2/+12
| | | | | | | | | | | | | | | | | So far, slcl would just close the connection with a client when the Content-Length of an incoming request exceeded the user quota, without any meaningful information given back to the user. Now, slcl responds with a HTML file with meaningful information about the error. Limitations: - While this commits has been successfully tested on ungoogled-chromium, LibreWolf (and I assume Firefox and any other derivates too) does not seem to receive the response from the server. - However, this issue only occurred during local testing, but not on remote instances.
* main.c: Fix double free(3) and refactor form handlingXavier Del Campo Romero2023-03-191-71/+74
| | | | | | | | | | | | | - When a non-empty username and an empty password was given, slcl would crash due to a double free(3). This happened because append_form would grow the form list before sanitizing the input and, since the output pointer was not updated to the caller function, the latter would attempt to free a now-old pointer. - Additionally, some compilers such as clang complained about the potential use of an uninitialized variable when calling forms_free. - Also, it was a good opportunity to refactor get_forms and its caller functions, as get_forms was not differentiate fatal errors from user input errors.
* main.c: Fix undefined value for curXavier Del Campo Romero2023-03-161-5/+6
| | | | | | | | | | As otherwise reported by clang 14.0.0: main.c:679:14: warning: variable 'cur' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] else if (available && quota_current(a, username, &cur)) This was a minor issue after all, as pq was not used unless available were set.
* main.c: Ensure essential directories on startupXavier Del Campo Romero2023-03-161-0/+72
| | | | | | So far, slcl failed with poorly described error messages when any of the essential directories were missing. Now, these are created automatically so that the initial setup is easier.
* main.c: Call form_free instead of repeating codeXavier Del Campo Romero2023-03-091-4/+1
|
* Implement public file sharingXavier Del Campo Romero2023-03-091-14/+182
| | | | | | | | | | | | | An HTML form is now added next to each regular file, that generates a POST request. Then, slcl replies with a HTML document with a link to the public resource (which are implemented as symlinks). Limitations: - For now, only regular files can be shared i.e., sharing directories is not possible. While feasible, it still requires a larger refactor to list_dir and resource_layout, so that read-only access to the directory is provided to anonymous users.
* Translate whitespace to '+' in append_formXavier Del Campo Romero2023-03-091-11/+8
| | | | Otherwise, every function calling get_forms must implement this.
* main.c: Always append trailing slash to directoriesXavier Del Campo Romero2023-03-081-38/+8
| | | | | | Otherwise, slcl would fail to generate the URLs for the elements inside a directory, because of how cust_dirname worked, which also turned out to be redundant.
* Call page_forbidden on invalid authXavier Del Campo Romero2023-03-081-18/+1
|
* Remove(3) f->tmpname from ctx_freeXavier Del Campo Romero2023-03-081-5/+0
| | | | | | Until now, f->tmpname was removed by move_file when the move operation succeeded. However, since a HTTP operation can fail before move_file is called, the temporary file must also be removed.
* main.c: Avoid leaking formsXavier Del Campo Romero2023-03-081-27/+39
|
* main.c: Print error message only on errno != EEXISTXavier Del Campo Romero2023-03-081-2/+3
|
* main.c: Replace + with whitespace for directoriesXavier Del Campo Romero2023-03-071-3/+5
|
* main.c: Fix memory leak if append_form failsXavier Del Campo Romero2023-03-071-1/+7
|
* main.c: Simplify code a bitXavier Del Campo Romero2023-03-071-8/+3
|
* Perform some minor optimizationsXavier Del Campo Romero2023-03-061-1/+1
|
* Implement user quotaXavier Del Campo Romero2023-03-061-3/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature allows admins to set a specific quota for each user, in MiB. This feature is particularly useful for shared instances, where unlimited user storage might be unfeasible or even dangerous for the server. Also, a nice HTML5 <progress> element has been added to the site that shows how much of the quota has been consumed. If no quota is set, slcl falls back to the default behaviour i.e., assume unlimited storage. Limitations: - While HTTP does specify a Content-Length, which determines the length of the whole request, it does not specify how many files are involved or their individual sizes. - Because of this, if multiple files are uploaded simultaneously, the whole request would be dropped if user quota is exceeded, even if not all files exceeded it. - Also, Content-Length adds the length of some HTTP boilerplate (e.g.: boundaries), but slcl must rely on this before accepting the whole request. In other words, this means some requests might be rejected by slcl because of the extra bytes caused by such boilerplate. - When the quota is exceeded, slcl must close the connection so that the rest of the transfer is cancelled. Unfortunately, this means no HTML can be sent back to the customer to inform about the situation.
* main.c: Simplify failed login responseXavier Del Campo Romero2023-03-061-16/+3
| | | | | - Location seems to have no effect on 401 HTTP responses. - Content-Type is already set by page_failed_login.
* Initial commitXavier Del Campo Romero2023-02-281-0/+935