aboutsummaryrefslogtreecommitdiff
path: root/main.c
Commit message (Collapse)AuthorAgeFilesLines
* main.c: Improve relative path detectionv0.2.1-rc4Xavier Del Campo Romero2024-02-201-6/+12
| | | | | | | | | Otherwise, the following resources would be considered valid: - /user/../test - /user/./test - /user/a/. - /user/a/./test
* main.c: Reject invalid /public/ requestsv0.2.1-rc3Xavier Del Campo Romero2024-02-201-1/+9
| | | | | | | | | | | | Otherwise: - slcl would accept /public/ (i.e., without a file name) as a valid resource. This would incorrectly map the public/ directory on the database, making slcl to return -1 because public/ is not a regular file. - slcl would accept directory names (e.g.: /public/dir/), which is never expected since slcl stores all public files into a single directory.
* main.c: Force valid cookie on check_lengthv0.2.1-rc2Xavier Del Campo Romero2024-02-201-1/+10
| | | | | Otherwise, a malicious user could send multipart/form-data requests without a valid cookie.
* main.c: const-qualify name and dirXavier Del Campo Romero2024-02-191-1/+1
| | | | | There was no reason why these should not be const-qualified. It was probably missed during the implementation.
* main.c: URL-encode created directoriesXavier Del Campo Romero2024-02-191-1/+8
| | | | | Otherwise, directories with special characters, such as "%", would not be accessible when performing the redirection.
* main.c: Use fstat(2) on move_fileXavier Del Campo Romero2024-02-191-24/+30
| | | | | This allows to reuse the same file descriptor to both open(2) and fstat(2) the file.
* Bump libweb to 0.3.0Xavier Del Campo Romero2024-02-191-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | The following commits fix a couple of security issues on libweb. Because of afe0681c0b26bb64bad55d7e86770f346cfa043e, slcl had to be updated to set up its struct http_cfg_post. commit afe0681c0b26bb64bad55d7e86770f346cfa043e Author: Xavier Del Campo Romero <xavi.dcr@tutanota.com> Date: Mon Feb 19 23:00:56 2024 +0100 Limit maximum multipart/form-data pairs and files A malicious user could inject an infinite number of empty files or key/value pairs into a request in order to exhaust the device's resources. commit 9d9e0c2979f43297b2ebbf84f14f064f3f9ced0e Author: Xavier Del Campo Romero <xavi.dcr@tutanota.com> Date: Mon Feb 19 22:49:09 2024 +0100 html.c: Avoid half-init objects on html_node_add_attr The previous implementation would leave half-initialised objects if one of the calls to strdup(3) failed. Now, n->attrs is only modified when all previous memory allocations were successful.
* main.c: Add missing relative path checkXavier Del Campo Romero2024-02-191-1/+5
|
* Upgrade to new libweb interfaceXavier Del Campo Romero2023-11-231-2/+12
| | | | | | | | | | | | | | | | | | | | | | | Recent commits from libweb brought a few breaking changes. The one below affected slcl, so it had to be updated according to the new interface: commit 98f5f52461b0c1ab1ee3331722bd32e2db9e1d41 Author: Xavier Del Campo <xavier.delcampo@midokura.com> Date: Thu Nov 16 12:23:08 2023 +0100 Split handler_loop from handler_listen Some applications might set up a struct handler object to listen on any port i.e., 0, but still need a way to determine which port number was eventually selected by the implementation. Therefore, handler_listen has been reduced to the server initialization bit, whereas the main loop has been split into its own function, namely handler_loop. Because of these changes, it no longer made sense for libweb to write the selected port to standard output, as this is something now applications can do on their own.
* main.c: Treat non-existing upload dir as non-fatalXavier Del Campo Romero2023-11-231-4/+52
| | | | | | | | | | When a user attempts to upload a file into a non-existing directory, slcl would not check whether the directory exists. Then, rename(3) would fail and slcl would treat this as a fatal error, effectively closing itself. Since this is an example of ill-formed user input, it must be treated as a non-fatal error, and instead slcl should return a bad request page.
* libweb: Bump new signature for http_decode_urlXavier Del Campo Romero2023-11-121-15/+30
| | | | | | The new signature allows callers to distinguish decoding errors from fatal errors. This is important for slcl to avoid crashing when ill-formed data is received from a client.
* main.c: Use BUFSIZ instead of arbitrary valueXavier Del Campo Romero2023-10-191-1/+1
| | | | | | | | | | According to C99 7.19.1p3: BUFSIZ is a macro that expands to an integer constant expression that is the size of the buffer used by the setbuf function. In other words, this means BUFSIZ is the most optimal length for a buffer that reads a file into memory in chunks using fread(3).
* Implement HEAD supportXavier Del Campo Romero2023-10-141-0/+56
|
* Apply slweb renaming to libwebXavier Del Campo Romero2023-10-111-3/+3
|
* main.c: Refactor calls to handler_addXavier Del Campo Romero2023-09-161-13/+39
|
* main.c: Remove string duplication in get_formsXavier Del Campo Romero2023-09-091-11/+2
| | | | | | | slweb now assumes application/x-www-form-urlencoded-data as text, so it now returns a null-terminated string on struct http_post member "data". This removes the need for slcl to call strdup(3) in order to obtain a null-terminated string.
* Check directory on uploadsXavier Del Campo Romero2023-09-091-3/+16
| | | | | | | | | For historical reasons, slweb used to check for a name called "dir" on multipart/form-data POST requests. However, stricly speaking this is application logic, so it has been now moved from slweb to slcl. This has resulted in a couple of breaking changes in slweb that had to be updated on slcl.
* main.c: Return 1 on null bufferXavier Del Campo Romero2023-09-091-0/+1
| | | | | Malformed POST requests might include no payload data. However, this is not considered a fatal error, but wrong user input.
* Adapt to slweb's include pathsXavier Del Campo Romero2023-07-211-3/+3
| | | | | slweb puts its header files into its own directory in order to avoid potential name clashing.
* Limit amount of search resultsXavier Del Campo Romero2023-07-111-1/+8
| | | | | | | | | | When a user enters a search term that is too generic, slcl would generate a long list of search results, where this generation could have a big impact on the server performance and its available resources. Therefore, it is reasonable to limit the number of search results to an arbitrary limit, so that users are forced to enter a more specific search term in order to achieve more relevant results.
* cftw: Allow user callback to stop recursive searchXavier Del Campo Romero2023-07-111-3/+3
| | | | | | | | | | | | | | | So far, cftw would search through all directories and files recursively, until all objects are processed. However, it is interesting for the user callback to be able to stop this process under specific circumstances. Now, cftw will pass a pointer to a bool, initialised to false by default, that can be optionally assigned to true by the user callback. Future commits will make use of this feature. For example, this will be used to limit the number of search results when a user enters a search term that is too generic and would otherwise generate a large amount of search results.
* main.c: Use path_isrel for search termsXavier Del Campo Romero2023-07-111-1/+1
| | | | | | Search terms cannot use the same strict rules used for filenames or directory names, as otherwise examples such as "*folder*/*IMG*" would not work.
* Allow admins to define their own stylesheetXavier Del Campo Romero2023-07-111-2/+106
| | | | | | | | | | | | slcl used to provide a hardcoded stylesheet. However, it would be desirable for some admins to provide a custom stylesheet without having to rebuild the application. Now, slcl creates a default stylesheet, namely style.css, into the target directory, that can be later modified by admins. While this might contradict the suckless philosophy a bit, hopefully some admins might find this new feature useful.
* main.c: Disallow invalid filenames or directory namesXavier Del Campo Romero2023-07-091-13/+52
| | | | | | | - Relative paths must not be used for filenames or directory names, such as "..", "." or "dir/..". - Paths with asterisks ('*') must not be allowed, to avoid confusion with wildcard expressions.
* Implement file/directory removalXavier Del Campo Romero2023-07-081-0/+332
| | | | | | | | | | | | | | | The following workflow has been implemented: - A new checkbox for each object inside a directory is shown. - When one or more objects are selected, the user submits a request through a HTML5 form. - Then, slcl will ask the user for confirmation, listing the selected objects, while reminding the user about the effects. - The user confirms the selection. - slcl removes the selected objects. All objects from non-empty directories are removed, too. - Finally, slcl redirects the user to the directory the request was made from.
* cftw: Allow directories to call the user callbackXavier Del Campo Romero2023-07-081-0/+3
| | | | | | | | This provides a few benefits: - This will allow searching for directories by name. - Future commits will allow to remove files and directories, so this change was also required for cftw.
* main.c: Fix use-after-free on failed search_fnXavier Del Campo Romero2023-07-071-1/+1
| | | | | | | | When search_fn fails, it must free `r` before `results`, as the former is assigned based on the latter - otherwise, it would lead to undefined behaviour. So far, only memory allocation errors would make search_fn to fail.
* main.c: Use ISO C99-compatible declaration for mainXavier Del Campo Romero2023-07-061-1/+1
| | | | | | | | | | | C99 ยง5.1.2.2.1 only defines the following declarations for main: - int main(void) - int main(int argc, char *argv[]) While the use of equivalent types (e.g.: char **argv) is allowed, const char ** would not be considered equivalent, and thus an invalid declaration depending on the implementation.
* Implement searchXavier Del Campo Romero2023-06-061-6/+224
| | | | | | This new feature adds a HTML form on each directory listing that allows to search files recursively, starting from the current user directory. Wildcard patterns are also allowed.
* Split wildcard_cmp into its own componentXavier Del Campo Romero2023-06-061-0/+1
| | | | Future commits will make use of this function outside handler.c.
* http.c: Decode URL resource and parameters separatelyXavier Del Campo Romero2023-05-011-10/+3
| | | | | | | | | Given the following contrived example request: /example%FB%DC&arg%DE1=examplevalue%AA slcl must decode each token separately, so that percent-encoded characters '&', '=' or '?' do not get accidently intepreted.
* Fix missing error checks for strtoul(3)Xavier Del Campo Romero2023-05-011-3/+4
|
* Implement file previewsXavier Del Campo Romero2023-04-231-7/+13
| | | | | | | | | | | | | When using HTTP "Content-Disposition: attachment;", users are forced to download files in order to use them, whereas others might prefer to open them in the browser. Therefore, now that URL parameters are supported by http.h, previews can be forced by adding "preview=1" or "preview=true" (case-insensitive) as a URL parameters. Any other parameters are ignored by slcl. For users, a "Preview" link has been added next to the "Share" button for each file.
* main.c: Use S_ISDIR in ensure_dirXavier Del Campo Romero2023-03-251-0/+5
|
* Define _POSIX_C_SOURCEXavier Del Campo Romero2023-03-241-0/+2
| | | | | This allows using the default compiler defined by make(1) (i.e., c99(1)), thus improving POSIX compatibility.
* Send response on quota exceededXavier Del Campo Romero2023-03-201-2/+12
| | | | | | | | | | | | | | | | | So far, slcl would just close the connection with a client when the Content-Length of an incoming request exceeded the user quota, without any meaningful information given back to the user. Now, slcl responds with a HTML file with meaningful information about the error. Limitations: - While this commits has been successfully tested on ungoogled-chromium, LibreWolf (and I assume Firefox and any other derivates too) does not seem to receive the response from the server. - However, this issue only occurred during local testing, but not on remote instances.
* main.c: Fix double free(3) and refactor form handlingXavier Del Campo Romero2023-03-191-71/+74
| | | | | | | | | | | | | - When a non-empty username and an empty password was given, slcl would crash due to a double free(3). This happened because append_form would grow the form list before sanitizing the input and, since the output pointer was not updated to the caller function, the latter would attempt to free a now-old pointer. - Additionally, some compilers such as clang complained about the potential use of an uninitialized variable when calling forms_free. - Also, it was a good opportunity to refactor get_forms and its caller functions, as get_forms was not differentiate fatal errors from user input errors.
* main.c: Fix undefined value for curXavier Del Campo Romero2023-03-161-5/+6
| | | | | | | | | | As otherwise reported by clang 14.0.0: main.c:679:14: warning: variable 'cur' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] else if (available && quota_current(a, username, &cur)) This was a minor issue after all, as pq was not used unless available were set.
* main.c: Ensure essential directories on startupXavier Del Campo Romero2023-03-161-0/+72
| | | | | | So far, slcl failed with poorly described error messages when any of the essential directories were missing. Now, these are created automatically so that the initial setup is easier.
* main.c: Call form_free instead of repeating codeXavier Del Campo Romero2023-03-091-4/+1
|
* Implement public file sharingXavier Del Campo Romero2023-03-091-14/+182
| | | | | | | | | | | | | An HTML form is now added next to each regular file, that generates a POST request. Then, slcl replies with a HTML document with a link to the public resource (which are implemented as symlinks). Limitations: - For now, only regular files can be shared i.e., sharing directories is not possible. While feasible, it still requires a larger refactor to list_dir and resource_layout, so that read-only access to the directory is provided to anonymous users.
* Translate whitespace to '+' in append_formXavier Del Campo Romero2023-03-091-11/+8
| | | | Otherwise, every function calling get_forms must implement this.
* main.c: Always append trailing slash to directoriesXavier Del Campo Romero2023-03-081-38/+8
| | | | | | Otherwise, slcl would fail to generate the URLs for the elements inside a directory, because of how cust_dirname worked, which also turned out to be redundant.
* Call page_forbidden on invalid authXavier Del Campo Romero2023-03-081-18/+1
|
* Remove(3) f->tmpname from ctx_freeXavier Del Campo Romero2023-03-081-5/+0
| | | | | | Until now, f->tmpname was removed by move_file when the move operation succeeded. However, since a HTTP operation can fail before move_file is called, the temporary file must also be removed.
* main.c: Avoid leaking formsXavier Del Campo Romero2023-03-081-27/+39
|
* main.c: Print error message only on errno != EEXISTXavier Del Campo Romero2023-03-081-2/+3
|
* main.c: Replace + with whitespace for directoriesXavier Del Campo Romero2023-03-071-3/+5
|
* main.c: Fix memory leak if append_form failsXavier Del Campo Romero2023-03-071-1/+7
|
* main.c: Simplify code a bitXavier Del Campo Romero2023-03-071-8/+3
|
generated by cgit v1.2.3 (git 2.39.1) at 2026-06-10 16:13:56 +0000