aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* auth.c: Ensure absolute path for a->dirXavier Del Campo Romero2023-03-251-13/+64
| | | | | Otherwise, slcl would create broken symbolic links if the user passes a relative path as command line argument.
* main.c: Use S_ISDIR in ensure_dirXavier Del Campo Romero2023-03-251-0/+5
|
* Define _POSIX_C_SOURCEXavier Del Campo Romero2023-03-247-1/+12
| | | | | This allows using the default compiler defined by make(1) (i.e., c99(1)), thus improving POSIX compatibility.
* http.c: Add missing #includeXavier Del Campo Romero2023-03-241-0/+1
| | | | As required by strncasecmp(3).
* Send response on quota exceededXavier Del Campo Romero2023-03-207-13/+136
| | | | | | | | | | | | | | | | | So far, slcl would just close the connection with a client when the Content-Length of an incoming request exceeded the user quota, without any meaningful information given back to the user. Now, slcl responds with a HTML file with meaningful information about the error. Limitations: - While this commits has been successfully tested on ungoogled-chromium, LibreWolf (and I assume Firefox and any other derivates too) does not seem to receive the response from the server. - However, this issue only occurred during local testing, but not on remote instances.
* README.md: Fix wrong linksXavier Del Campo Romero2023-03-201-4/+4
|
* README.md: Update according to current statusXavier Del Campo Romero2023-03-191-14/+26
|
* main.c: Fix double free(3) and refactor form handlingXavier Del Campo Romero2023-03-191-71/+74
| | | | | | | | | | | | | - When a non-empty username and an empty password was given, slcl would crash due to a double free(3). This happened because append_form would grow the form list before sanitizing the input and, since the output pointer was not updated to the caller function, the latter would attempt to free a now-old pointer. - Additionally, some compilers such as clang complained about the potential use of an uninitialized variable when calling forms_free. - Also, it was a good opportunity to refactor get_forms and its caller functions, as get_forms was not differentiate fatal errors from user input errors.
* main.c: Fix undefined value for curXavier Del Campo Romero2023-03-161-5/+6
| | | | | | | | | | As otherwise reported by clang 14.0.0: main.c:679:14: warning: variable 'cur' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] else if (available && quota_current(a, username, &cur)) This was a minor issue after all, as pq was not used unless available were set.
* auth.c: Add friendly reminderXavier Del Campo Romero2023-03-161-1/+2
|
* Add man page for usergen(1)Xavier Del Campo Romero2023-03-162-0/+95
|
* Make usergen a bit more usefulXavier Del Campo Romero2023-03-162-7/+40
| | | | | | So far, usergen printed a JSON object over standard output that had to be manually copied into db.json. Now, this step is done automatically, thanks to jq(1). OTOH, user directory is now also created by usergen.
* page.c: Set Content-Disposition when serving filesXavier Del Campo Romero2023-03-161-5/+96
| | | | | | | | | | | | | | So far, slcl used the default browser behaviour (i.e., Content-Disposition: inline), which means files were typically shown on the web browser itself. However, this caused two issues: - Users would have to right-click -> "Save Link As..." to download a file, which might be inconvenient for some users. - The original file name would not be retrieved for publicly shared files. Now, file download is always requested to the browser, and the original file path is retrieved via readlink(2).
* main.c: Ensure essential directories on startupXavier Del Campo Romero2023-03-161-0/+72
| | | | | | So far, slcl failed with poorly described error messages when any of the essential directories were missing. Now, these are created automatically so that the initial setup is easier.
* slcl.1: Update TODOXavier Del Campo Romero2023-03-161-1/+1
| | | | | - User quota was implemented by commit ff8da797a. - Public file sharing was implemented by commit 2e1b1313.
* page.c: Fix wrong error messageXavier Del Campo Romero2023-03-091-1/+1
|
* main.c: Call form_free instead of repeating codeXavier Del Campo Romero2023-03-091-4/+1
|
* Implement public file sharingXavier Del Campo Romero2023-03-093-15/+369
| | | | | | | | | | | | | An HTML form is now added next to each regular file, that generates a POST request. Then, slcl replies with a HTML document with a link to the public resource (which are implemented as symlinks). Limitations: - For now, only regular files can be shared i.e., sharing directories is not possible. While feasible, it still requires a larger refactor to list_dir and resource_layout, so that read-only access to the directory is provided to anonymous users.
* page.c: Provide meaningful description on HTTP 404Xavier Del Campo Romero2023-03-091-8/+28
|
* page.c: Implement function for common <head> nodesXavier Del Campo Romero2023-03-091-34/+55
| | | | This will be used by future commits.
* Translate whitespace to '+' in append_formXavier Del Campo Romero2023-03-091-11/+8
| | | | Otherwise, every function calling get_forms must implement this.
* Move decode_hex into its own fileXavier Del Campo Romero2023-03-095-22/+67
| | | | | | | - Error detection against strotul(3) has been improved, as done in other places. - New function encode_hex has been implemented, which will be used by future commits.
* http.c: Minor formatting changeXavier Del Campo Romero2023-03-081-2/+1
|
* page.c: Set common <head> parametersXavier Del Campo Romero2023-03-081-3/+7
|
* main.c: Always append trailing slash to directoriesXavier Del Campo Romero2023-03-081-38/+8
| | | | | | Otherwise, slcl would fail to generate the URLs for the elements inside a directory, because of how cust_dirname worked, which also turned out to be redundant.
* Call page_forbidden on invalid authXavier Del Campo Romero2023-03-081-18/+1
|
* Remove(3) f->tmpname from ctx_freeXavier Del Campo Romero2023-03-082-10/+10
| | | | | | Until now, f->tmpname was removed by move_file when the move operation succeeded. However, since a HTTP operation can fail before move_file is called, the temporary file must also be removed.
* Update dynstrXavier Del Campo Romero2023-03-081-0/+0
|
* server.c: Fix wrong size for memcpy(3)Xavier Del Campo Romero2023-03-081-4/+5
|
* main.c: Avoid leaking formsXavier Del Campo Romero2023-03-081-27/+39
|
* main.c: Print error message only on errno != EEXISTXavier Del Campo Romero2023-03-081-2/+3
|
* page.c: Show units for user quotaXavier Del Campo Romero2023-03-081-22/+52
|
* page.c: Sort elements alphabeticallyXavier Del Campo Romero2023-03-081-26/+64
|
* html.c: Allow empty strings on html_encodeXavier Del Campo Romero2023-03-081-0/+6
|
* server.c: Minor const-correctness improvementXavier Del Campo Romero2023-03-071-1/+1
|
* main.c: Replace + with whitespace for directoriesXavier Del Campo Romero2023-03-071-3/+5
|
* main.c: Fix memory leak if append_form failsXavier Del Campo Romero2023-03-071-1/+7
|
* main.c: Simplify code a bitXavier Del Campo Romero2023-03-071-8/+3
|
* cftw.c: Add missing call to closedir(2)Xavier Del Campo Romero2023-03-071-4/+14
|
* Perform some minor optimizationsXavier Del Campo Romero2023-03-062-2/+2
|
* Implement user quotaXavier Del Campo Romero2023-03-0614-35/+393
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature allows admins to set a specific quota for each user, in MiB. This feature is particularly useful for shared instances, where unlimited user storage might be unfeasible or even dangerous for the server. Also, a nice HTML5 <progress> element has been added to the site that shows how much of the quota has been consumed. If no quota is set, slcl falls back to the default behaviour i.e., assume unlimited storage. Limitations: - While HTTP does specify a Content-Length, which determines the length of the whole request, it does not specify how many files are involved or their individual sizes. - Because of this, if multiple files are uploaded simultaneously, the whole request would be dropped if user quota is exceeded, even if not all files exceeded it. - Also, Content-Length adds the length of some HTTP boilerplate (e.g.: boundaries), but slcl must rely on this before accepting the whole request. In other words, this means some requests might be rejected by slcl because of the extra bytes caused by such boilerplate. - When the quota is exceeded, slcl must close the connection so that the rest of the transfer is cancelled. Unfortunately, this means no HTML can be sent back to the customer to inform about the situation.
* Add cftwXavier Del Campo Romero2023-03-064-0/+74
| | | | | | | | | | | POSIX functions ftw(3) and nftw(3) do not allow passing an opaque pointer to the callback they call, so it forces the use of statically allocated data. ctfw (from "custom ftw") is a custom implementation that solves this, while also removing unneeded stuff. This function will be used by future commits.
* README.md: Fix broken link to usergenXavier Del Campo Romero2023-03-061-4/+4
|
* Perform some minor optimizationsXavier Del Campo Romero2023-03-063-10/+3
|
* main.c: Simplify failed login responseXavier Del Campo Romero2023-03-061-16/+3
| | | | | - Location seems to have no effect on 401 HTTP responses. - Content-Type is already set by page_failed_login.
* http.c: Compare headers as case-insensitiveXavier Del Campo Romero2023-03-041-1/+1
| | | | | Web browsers such as lynx send "Content-length" instead of "Content-Length" (as done by LibreWolf and Chromium).
* http.c: Use persistent cookiesXavier Del Campo Romero2023-03-041-0/+40
| | | | | | Cookies without "Expires" are considered non-persistent and thus can be removed by the web browser. Instead, slcl now sets persistent cookies that last for 1 year.
* http.c: Improve error detection for strotull(3)Xavier Del Campo Romero2023-03-041-1/+12
| | | | | set_length relies on user input to determine Content-Length, so it should be considered unreliable.
* Fix memory leak on failed realloc(3)Xavier Del Campo Romero2023-03-044-33/+79
| | | | | | | | | | According to C99 ยง7.20.3.4: If memory for the new object cannot be allocated, the old object is not deallocated and its value is unchanged. Therefore, a temporary pointer must be used to ensure the original object can still be deallocated should realloc(3) return a null pointer.
* Add man pageXavier Del Campo Romero2023-02-281-0/+123
|
generated by cgit v1.2.3 (git 2.39.1) at 2026-06-22 14:56:27 +0000