aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Makefile: add install targetXavier Del Campo Romero2023-09-273-0/+33
|
* slcl.1: Remove obsolete TODOXavier Del Campo Romero2023-09-271-3/+0
| | | | | | | | | | This feature was already implemented by: commit 0822a982ef3b085dc109ec373ff537974503eb04 Author: Xavier Del Campo Romero <xavi.dcr@tutanota.com> Date: Sat Jul 8 00:54:59 2023 +0200 Implement file/directory removal
* main.c: Refactor calls to handler_addXavier Del Campo Romero2023-09-161-13/+39
|
* usergen: Remove dependency against sha256sum(1)Xavier Del Campo Romero2023-09-161-1/+1
| | | | | | sha256sum(1) is a GNU utility that might not be available under some POSIX systems. Since OpenSSL is already a dependency, it makes sense to reuse it to generate SHA256 digests.
* usergen: Remove dependency against xxd(1)Xavier Del Campo Romero2023-09-162-6/+15
| | | | | xxd(1) is closely related to vim(1), might not be available under some POSIX systems.
* usergen: Reject non-numeric, invalid quotaXavier Del Campo Romero2023-09-161-0/+1
|
* Reduce minimum required major version for OpenSSLXavier Del Campo Romero2023-09-162-2/+2
| | | | | slcl has been successfully tested with OpenSSL 2.0 on an OpenBSD 7.3 host.
* auth.c: Add missing includeXavier Del Campo Romero2023-09-151-0/+1
| | | | | As opposed to other integer constants such as ULLONG_MAX, SIZE_MAX is defined by stdint.h, not limits.h.
* main.c: Remove string duplication in get_formsXavier Del Campo Romero2023-09-092-11/+2
| | | | | | | slweb now assumes application/x-www-form-urlencoded-data as text, so it now returns a null-terminated string on struct http_post member "data". This removes the need for slcl to call strdup(3) in order to obtain a null-terminated string.
* Check directory on uploadsXavier Del Campo Romero2023-09-092-3/+16
| | | | | | | | | For historical reasons, slweb used to check for a name called "dir" on multipart/form-data POST requests. However, stricly speaking this is application logic, so it has been now moved from slweb to slcl. This has resulted in a couple of breaking changes in slweb that had to be updated on slcl.
* page.c: Update project URLXavier Del Campo Romero2023-09-091-1/+1
|
* main.c: Return 1 on null bufferXavier Del Campo Romero2023-09-091-0/+1
| | | | | Malformed POST requests might include no payload data. However, this is not considered a fatal error, but wrong user input.
* Bump slwebXavier Del Campo Romero2023-09-071-0/+0
| | | | Last commits introduced several minor bugfixes and improvements.
* Add screenshotsXavier Del Campo Romero2023-08-083-0/+6
|
* Bump slwebXavier Del Campo Romero2023-08-081-0/+0
| | | | | | | | | d55b84f68b90fe5c2521724d0c22ebf22e62b0b4 introduces a bugfix: Author: Xavier Del Campo Romero <xavi.dcr@tutanota.com> Date: Tue Aug 8 00:32:21 2023 +0200 html.c: Fix wrong encoding for '>' and '<'
* Bump slwebXavier Del Campo Romero2023-08-021-0/+0
|
* CMakeLists.txt: Set project language to CXavier Del Campo Romero2023-08-021-1/+1
| | | | | Otherwise, CMake by default tests the system C++ compiler, but this is not a requirement for slcl.
* Makefile: run the clean target recursivelyXavier Del Campo Romero2023-08-011-0/+2
|
* Bump slwebXavier Del Campo Romero2023-08-011-0/+0
|
* Makefile: Add FORCE targetXavier Del Campo Romero2023-08-011-2/+4
| | | | | | When added to targets $(DYNSTR) and $(SLWEB), this would force running the recursive Makefiles, which might then (or might not) rebuild targets.
* Do some minor rebrandingXavier Del Campo Romero2023-08-013-12/+13
| | | | | | Despite designed around portability and minimalism, I feel slcl no longer aligns with the philosophical views from the suckless project. Therefore, I think it was appropriate to unlink its branding from it.
* README.md: Inform about -t command line optionXavier Del Campo Romero2023-07-301-0/+21
|
* Move slweb to new URLXavier Del Campo Romero2023-07-283-5/+5
|
* README.md: Add references to slwebXavier Del Campo Romero2023-07-211-1/+4
| | | | | | slweb is the HTTP/1.1 server implementation and utilities that slcl originally implemented, which have now been split into a separate repository.
* Remove dynstr as a submoduleXavier Del Campo Romero2023-07-212-3/+0
| | | | It is now provided by slweb instead.
* Adapt to slweb's include pathsXavier Del Campo Romero2023-07-215-8/+8
| | | | | slweb puts its header files into its own directory in order to avoid potential name clashing.
* Adapt build system to slwebXavier Del Campo Romero2023-07-212-19/+15
| | | | | Now, slweb is a library slcl depends on, which includes the HTTP/1.1 server implementation, as well as other utilities.
* Remove files now provided by slwebXavier Del Campo Romero2023-07-218-3113/+0
|
* Import slwebXavier Del Campo Romero2023-07-212-0/+3
| | | | | | | slweb contains the HTTP/1.1 server implementation and surrounding utilities that are used by slcl. The motivation behind this was to allow these components to be used by other projects, as well as effectively making slcl smaller and more modular.
* Makefile: Allow users to define LDFLAGSXavier Del Campo Romero2023-07-161-2/+1
| | | | | This should allow for easier packaging if extra linker flags are required.
* Limit amount of search resultsXavier Del Campo Romero2023-07-113-3/+82
| | | | | | | | | | When a user enters a search term that is too generic, slcl would generate a long list of search results, where this generation could have a big impact on the server performance and its available resources. Therefore, it is reasonable to limit the number of search results to an arbitrary limit, so that users are forced to enter a more specific search term in order to achieve more relevant results.
* cftw: Allow user callback to stop recursive searchXavier Del Campo Romero2023-07-113-10/+19
| | | | | | | | | | | | | | | So far, cftw would search through all directories and files recursively, until all objects are processed. However, it is interesting for the user callback to be able to stop this process under specific circumstances. Now, cftw will pass a pointer to a bool, initialised to false by default, that can be optionally assigned to true by the user callback. Future commits will make use of this feature. For example, this will be used to limit the number of search results when a user enters a search term that is too generic and would otherwise generate a large amount of search results.
* main.c: Use path_isrel for search termsXavier Del Campo Romero2023-07-111-1/+1
| | | | | | Search terms cannot use the same strict rules used for filenames or directory names, as otherwise examples such as "*folder*/*IMG*" would not work.
* Allow admins to define their own stylesheetXavier Del Campo Romero2023-07-117-57/+199
| | | | | | | | | | | | slcl used to provide a hardcoded stylesheet. However, it would be desirable for some admins to provide a custom stylesheet without having to rebuild the application. Now, slcl creates a default stylesheet, namely style.css, into the target directory, that can be later modified by admins. While this might contradict the suckless philosophy a bit, hopefully some admins might find this new feature useful.
* page.c: Allow add_element to hide checkboxesXavier Del Campo Romero2023-07-091-4/+4
| | | | | Since removing files or directories is currently not an option in searches, it is better to leave checkboxes out to avoid confusion.
* page.c: Remove back button from searchesXavier Del Campo Romero2023-07-091-43/+0
| | | | | | | | - The back button would not return to the previous directory, but to the user root directory. - While this could have been solved easily (e.g.: by inserting the referrer directory into the form), it would have implied extra and unneeded complexity.
* wildcard_cmp.c: Fix out-of-bounds cmpXavier Del Campo Romero2023-07-091-1/+2
| | | | | | | | | | | | | | | When the distance between '*' on a wildcard expression was larger than the string to compare with, this would cause an out-of-bounds read because `n` was not being limited to the strlen(3) from the input string. Example: - s="c", p="*cc*", casecmp=false Here, the distance between the first and second '*' is 2 bytes, which is longer than the input string itself (1 byte, not counting the terminating null byte '\0').
* main.c: Disallow invalid filenames or directory namesXavier Del Campo Romero2023-07-091-13/+52
| | | | | | | - Relative paths must not be used for filenames or directory names, such as "..", "." or "dir/..". - Paths with asterisks ('*') must not be allowed, to avoid confusion with wildcard expressions.
* http.c: Disallow forbidden filenames during uploadXavier Del Campo Romero2023-07-091-0/+8
| | | | | | | - '.' or '..' must not be used for filenames. - Filenames must not contain forward slashes ('/'). - Filenames must not contain asterisks ('*') to avoid confusion with wildcard expressions.
* http.c: Use case-insensitive compare for Content-DispositionXavier Del Campo Romero2023-07-091-1/+1
| | | | | HTTP headers are case-insensitive, so the implementation must accept Content-Diposition, content-disposition or any other variation.
* Implement file/directory removalXavier Del Campo Romero2023-07-083-1/+698
| | | | | | | | | | | | | | | The following workflow has been implemented: - A new checkbox for each object inside a directory is shown. - When one or more objects are selected, the user submits a request through a HTML5 form. - Then, slcl will ask the user for confirmation, listing the selected objects, while reminding the user about the effects. - The user confirms the selection. - slcl removes the selected objects. All objects from non-empty directories are removed, too. - Finally, slcl redirects the user to the directory the request was made from.
* cftw: Allow directories to call the user callbackXavier Del Campo Romero2023-07-082-1/+9
| | | | | | | | This provides a few benefits: - This will allow searching for directories by name. - Future commits will allow to remove files and directories, so this change was also required for cftw.
* page.c: Return HTTP_STATUS_OK on successful page_searchXavier Del Campo Romero2023-07-081-1/+1
| | | | | This was probably a copy-paste issue when implementing page_search based on page_quota_exceeded.
* main.c: Fix use-after-free on failed search_fnXavier Del Campo Romero2023-07-071-1/+1
| | | | | | | | When search_fn fails, it must free `r` before `results`, as the former is assigned based on the latter - otherwise, it would lead to undefined behaviour. So far, only memory allocation errors would make search_fn to fail.
* cftw.c: Check errors from readdir(3)Xavier Del Campo Romero2023-07-061-2/+12
| | | | | | According to POSIX.1-2017, applications are advised to assign errno(3) to 0 before a call to readdir(3), and compare errno(3) after the call to check for errors.
* main.c: Use ISO C99-compatible declaration for mainXavier Del Campo Romero2023-07-061-1/+1
| | | | | | | | | | | C99 ยง5.1.2.2.1 only defines the following declarations for main: - int main(void) - int main(int argc, char *argv[]) While the use of equivalent types (e.g.: char **argv) is allowed, const char ** would not be considered equivalent, and thus an invalid declaration depending on the implementation.
* server.c: Fix typoXavier Del Campo Romero2023-07-061-1/+1
|
* http.c: Accept resources with '&' or '?'Xavier Del Campo Romero2023-07-061-2/+4
| | | | | Otherwise, client requests to resources such as '/me & you', '/?' or '/??preview=1' would fail.
* server.c: Fix undefined behaviour on >1 clientsXavier Del Campo Romero2023-07-031-45/+45
| | | | | | | | | | | | | | server.c kept an array of all of its active clients, calling realloc(3) everytime its size had to be modified. However, reallocating this array had the undesired consequence of moving other active clients to other memory locations. Potentially, this would result in dangling pointers from other components that also kept pointers to struct server_client instances e.g.: handler.c. For this reason, the array-based approach has been completely dropped, in favour of a doubly-linked list.
* Implement searchXavier Del Campo Romero2023-06-063-7/+476
| | | | | | This new feature adds a HTML form on each directory listing that allows to search files recursively, starting from the current user directory. Wildcard patterns are also allowed.
generated by cgit v1.2.3 (git 2.39.1) at 2026-07-19 20:46:23 +0000