From d96e5685ee072d5fd80c562089c1080a53673187 Mon Sep 17 00:00:00 2001 From: Xavier Del Campo Romero Date: Sat, 14 Oct 2023 13:05:58 +0200 Subject: [PATCH] auth.c: Fix potential signed integer overflow For platforms where int is a 16-bit data type, this operation might overflow and possibly cause either unexpected behaviour and/or a compiler warning. Therefore, it is safer to promote each integer constant accordingly. --- auth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/auth.c b/auth.c index 774e16a..1db2683 100644 --- a/auth.c +++ b/auth.c @@ -422,7 +422,7 @@ int auth_quota(const struct auth *const a, const char *const user, *available = true; *quota = strtoull(qs, &end, 10); - const unsigned long long mul = 1024 * 1024; + const unsigned long long mul = 1024ul * 1024ul; if (errno || *end != '\0') { @@ -436,7 +436,7 @@ int auth_quota(const struct auth *const a, const char *const user, goto end; } - *quota *= 1024 * 1024; + *quota *= mul; break; } }