xavi/slcl/main.c, branch thumbnail Small and lightweight cloud storage written in C99 and POSIX.1-2008. https://gitea.privatedns.org/xavi/slcl/atom?h=thumbnail 2023-07-11T11:30:17+00:00 WIP thumbnail code 2023-07-11T11:30:17+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-08T01:24:32+00:00 urn:sha1:aae26c510dd8a1228848d75c33a07eb992f8dd2a Limit amount of search results 2023-07-11T11:27:49+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-11T11:11:50+00:00 urn:sha1:38f3f82a77ed4782a9c4e1b4e5a6d9d4c71390a2 When a user enters a search term that is too generic, slcl would generate a long list of search results, where this generation could have a big impact on the server performance and its available resources. Therefore, it is reasonable to limit the number of search results to an arbitrary limit, so that users are forced to enter a more specific search term in order to achieve more relevant results. cftw: Allow user callback to stop recursive search 2023-07-11T11:27:49+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-11T11:08:06+00:00 urn:sha1:59e17afe291f9df52d2334b92e88a889c2fe8f6a So far, cftw would search through all directories and files recursively, until all objects are processed. However, it is interesting for the user callback to be able to stop this process under specific circumstances. Now, cftw will pass a pointer to a bool, initialised to false by default, that can be optionally assigned to true by the user callback. Future commits will make use of this feature. For example, this will be used to limit the number of search results when a user enters a search term that is too generic and would otherwise generate a large amount of search results. main.c: Use path_isrel for search terms 2023-07-11T11:27:49+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-11T11:26:06+00:00 urn:sha1:48b171335c213091cdf682c98ad784dc5c8456da Search terms cannot use the same strict rules used for filenames or directory names, as otherwise examples such as "*folder*/*IMG*" would not work. Allow admins to define their own stylesheet 2023-07-10T23:49:12+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-10T23:20:39+00:00 urn:sha1:e79e955d93e24a192c9bf94181294d0797e9fded slcl used to provide a hardcoded stylesheet. However, it would be desirable for some admins to provide a custom stylesheet without having to rebuild the application. Now, slcl creates a default stylesheet, namely style.css, into the target directory, that can be later modified by admins. While this might contradict the suckless philosophy a bit, hopefully some admins might find this new feature useful. main.c: Disallow invalid filenames or directory names 2023-07-09T03:54:53+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-09T02:41:55+00:00 urn:sha1:b5282b23653b3a46ab6ae2d84049abadcc8a8a1d - Relative paths must not be used for filenames or directory names, such as "..", "." or "dir/..". - Paths with asterisks ('*') must not be allowed, to avoid confusion with wildcard expressions. Implement file/directory removal 2023-07-08T01:08:07+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-07T22:54:59+00:00 urn:sha1:0822a982ef3b085dc109ec373ff537974503eb04 The following workflow has been implemented: - A new checkbox for each object inside a directory is shown. - When one or more objects are selected, the user submits a request through a HTML5 form. - Then, slcl will ask the user for confirmation, listing the selected objects, while reminding the user about the effects. - The user confirms the selection. - slcl removes the selected objects. All objects from non-empty directories are removed, too. - Finally, slcl redirects the user to the directory the request was made from. cftw: Allow directories to call the user callback 2023-07-08T00:30:31+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-08T00:30:31+00:00 urn:sha1:74ca76a58fca114140d0d0cc13a1216d6dffbee0 This provides a few benefits: - This will allow searching for directories by name. - Future commits will allow to remove files and directories, so this change was also required for cftw. main.c: Fix use-after-free on failed search_fn 2023-07-07T20:04:01+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-07T20:01:13+00:00 urn:sha1:960a35a02fa8c98036e73be8fee9ea3f1c0888e9 When search_fn fails, it must free `r` before `results`, as the former is assigned based on the latter - otherwise, it would lead to undefined behaviour. So far, only memory allocation errors would make search_fn to fail. main.c: Use ISO C99-compatible declaration for main 2023-07-05T22:56:27+00:00 Xavier Del Campo Romero xavi.dcr@tutanota.com 2023-07-05T22:56:19+00:00 urn:sha1:36ff7d81432308ba430414180c0ab7a41af228ba C99 ยง5.1.2.2.1 only defines the following declarations for main: - int main(void) - int main(int argc, char *argv[]) While the use of equivalent types (e.g.: char **argv) is allowed, const char ** would not be considered equivalent, and thus an invalid declaration depending on the implementation.